Issue metadata
Sign in to add a comment
|
Re-enable 3 unittests in chromeos/ap/classifier |
||||||||||||||||||||||||
Issue descriptionWith go-1.10 installed in the chroot, unittests for chromeos-base/ap-daemons fail with: ap-daemons-0.0.3-r3960: --- FAIL: TestLBStatusCodeError (0.00s) ap-daemons-0.0.3-r3960: linebacker_client_test.go:161: unexpected error type, expected *StatusError, got *url.Error ap-daemons-0.0.3-r3960: --- FAIL: TestSafeBrowsingStatusCodeError (0.00s) ap-daemons-0.0.3-r3960: safebrowsing_test.go:284: unexpected error type, expected *StatusError, got *url.Error ap-daemons-0.0.3-r3960: --- FAIL: TestStatusCodeError (0.00s) ap-daemons-0.0.3-r3960: safesearch_client_test.go:91: unexpected error type, expected *StatusError, got *url.Error ap-daemons-0.0.3-r3960: FAIL ap-daemons-0.0.3-r3960: FAIL chromeos/ap/classifier 1.182s For more details, see https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_toolchain/builds/1029 Steps to reproduce: 1. Cherry pick https://chromium-review.googlesource.com/947328 in chromiumos-overlay 2. sudo emerge dev-lang/go cross-armv7a-cros-linux-gnueabi/go 3. FEATURES=test emerge-whirlwind chromeos-base/ap-daemons
,
Apr 3 2018
Please take a look. The test passes with go-1.9 but fails with go-1.10. The release notes for go-1.10 mention a change to ResolveReference() in net/url that might be the underlying cause of these failures: https://golang.org/doc/go1.10#net/url
,
Apr 5 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/7ba02bbd4253c1465d5c0a3afd8f2734ae2b83ba commit 7ba02bbd4253c1465d5c0a3afd8f2734ae2b83ba Author: Rahul Chaudhry <rahulchaudhry@chromium.org> Date: Thu Apr 05 05:53:23 2018
,
Apr 5 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/8bb6bb459240ff745012e96cb6ecd3934f4bacb1 commit 8bb6bb459240ff745012e96cb6ecd3934f4bacb1 Author: Rahul Chaudhry <rahulchaudhry@chromium.org> Date: Thu Apr 05 05:53:23 2018
,
Apr 5 2018
The remaining item on this issue is fixing the 3 unittests that are failing and then re-enabling them.
,
Apr 7 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/d879974392018ddea999057ff2beebcd04176ab0 commit d879974392018ddea999057ff2beebcd04176ab0 Author: Mitchell Gildenberg <mgild@google.com> Date: Sat Apr 07 02:50:46 2018
,
Apr 9 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by rahulchaudhry@chromium.org
, Apr 3 2018