New issue
Advanced search Search tips

Issue 828544 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Single pixel height lines don't render at decimal offsets

Reported by albertx...@slack-corp.com, Apr 3 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36

Example URL:
https://jsfiddle.net/hv2592u2/5/

Steps to reproduce the problem:
1. Open https://jsfiddle.net/hv2592u2/5/
2. Zoom out 1 step to 90%

What is the expected behavior?
The two 1px height elements (one a border, another a 1px height div) should render

What went wrong?
Both elements are invisible

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 65.0.3325.181  Channel: stable
OS Version: OS X 10.13.3
Flash Version:
 
Screen Shot 2018-04-03 at 12.04.25.png
127 KB View Download
Screen Shot 2018-04-03 at 12.04.38.png
118 KB View Download
This is a regression, it worked fine from at least Dev release 61.0.3141.7 (snapshot 482149, bb2ecc3904828a1619cf7c55d66b2b19731782e8) and regressed by 61.0.3159.5 (snapshot 485143, 4b9102f9588fb6cf639a6165fd4777658d5ade0d), which can be verified by downloading the two snapshots and comparing the JSFiddle page I linked above.
Labels: Needs-Triage-M65

Comment 3 by tkent@chromium.org, Apr 4 2018

Components: -Blink Blink>Layout
Labels: -Type-Bug Needs-Bisect Type-Bug-Regression

Comment 4 by woxxom@gmail.com, Apr 4 2018

Also observed in Windows 7, including Chrome Canary.

Bisect info: 482226 (good) - 482233 (bad)
https://chromium.googlesource.com/chromium/src/+log/b88e3785..eb499bd0?pretty=fuller
Suspecting r482233 = eb499bd02c68f68b5f74d534a673e920f8e7a5e6 = https://crrev.com/c/525536 by karlo@opera.com
"Move rounding up to 1.0f of border widths to the painting stage."
Landed in 61.0.3142.0

This CL caused other regressions:
https://bugs.chromium.org/p/chromium/issues/list?q=eb499bd02c68f68b5f74d534a673e920f8e7a5e6
If the original developer doesn't have the time to work on a fix, maybe someone else should be assigned?
Cc: susan.boorgula@chromium.org ka...@opera.com
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision Target-67 RegressedIn-61 Triaged-ET Target-66 M-67 FoundIn-66 FoundIn-67 Target-65 FoundIn-65 OS-Linux OS-Windows Pri-1
Owner: schenney@chromium.org
Status: Assigned (was: Unconfirmed)
albertxing@ Thanks for the issue.

Able to reproduce this issue on Windows 10, Mac OS 10.12.6 and Ubuntu 14.04 on the latest Canary 67.0.3387.0 and Stable 65.0.3325.181 as per the original comment.

Bisect Information:
===================
Good Build: 61.0.3141.0 (Revision - 482153)
Bad Build : 61.0.3142.0 (Revision - 482491)

On executing the per-revision bisect script, below is the Changelog URL:

https://chromium.googlesource.com/chromium/src/+log/1ade9dfba70113fb2e9898bb187248ed18d07a05..eb499bd02c68f68b5f74d534a673e920f8e7a5e6

From the above Changelog, suspecting the below change:
Reviewed-on: https://chromium-review.googlesource.com/525536

As mails to karlo@ are getting bounced, assigning the bug to Reviewer schenney@.
schenney@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner.

Thanks.
Cc: -ka...@opera.com
Labels: -Pri-1 -Target-66 Pri-2
I think I might finally revert this, or figure out how to fix it given all the problem it caused under zoom.

Will have to wait until after background image work.

Regressed way back so doesn't count as a regression now.
Did you ever get around to revert this schenney?
No, I didn't. I was planning to look to fix the issues this quarter.
 Issue 911494  has been merged into this issue.

Sign in to add a comment