EasyUnlockTpmKeyManagerTest.CreateKeyPairMultipleCallbacks Fails Locally |
|||
Issue descriptionEasyUnlockTpmKeyManagerTest.CreateKeyPairMultipleCallbacks is failing locally for me, though it seems to be okay on the buildbots. Haven't investigated this any deeper. Here are my gn args: is_debug = false dcheck_always_on = true is_component_build = true target_os = "chromeos" use_goma = true [ RUN ] EasyUnlockTpmKeyManagerTest.CreateKeyPairMultipleCallbacks [45135:45181:0403/114631.679249:3112974718787:FATAL:nss_util.cc(438)] Check failed: thread_checker_.CalledOnValidThread(). #0 0x7fe4022e5d7c base::debug::StackTrace::StackTrace() #1 0x7fe40230cacb logging::LogMessage::~LogMessage() #2 0x7fe401b27145 crypto::InitializeNSSForChromeOSUser() #3 0x000001efb005 crypto::ScopedTestNSSChromeOSUser::ScopedTestNSSChromeOSUser() #4 0x000002270b9d chromeos::(anonymous namespace)::EasyUnlockTpmKeyManagerTest::InitTestNssUserOnIOThread() #5 0x7fe40238f4f2 base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply() #6 0x7fe4022e6654 base::debug::TaskAnnotator::RunTask() #7 0x7fe402318cb9 base::internal::IncomingTaskQueue::RunTask() #8 0x7fe40231c80b base::MessageLoop::RunTask() #9 0x7fe40231cbaa base::MessageLoop::DeferOrRunPendingTask() #10 0x7fe40231ce0c base::MessageLoop::DoWork() #11 0x7fe40231f239 base::MessagePumpLibevent::Run() #12 0x7fe40231c139 base::MessageLoop::Run() #13 0x7fe402352e59 base::RunLoop::Run() #14 0x7fe402392b07 base::Thread::Run() #15 0x7fe4003d44d4 content::BrowserProcessSubThread::IOThreadRun() #16 0x7fe4003d4474 content::BrowserProcessSubThread::Run() #17 0x7fe4023930bd base::Thread::ThreadMain() #18 0x7fe40238f1ef base::(anonymous namespace)::ThreadFunc() #19 0x7fe40453f494 start_thread #20 0x7fe3f74cca8f clone
,
Apr 3 2018
,
Apr 3 2018
For the sake of posterity, the repro requires running CreateKeyPair with CreateKeyPairMultipleCallbacks. out/Default/unit_tests --gtest_filter=EasyUnlockTpmKeyManagerTest.CreateKeyPair:EasyUnlockTpmKeyManagerTest.CreateKeyPairMultipleCallbacks
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf3ff80ba71e29d522158628a3cced1f9d2e0f2b commit cf3ff80ba71e29d522158628a3cced1f9d2e0f2b Author: James Hawkins <jhawkins@chromium.org> Date: Tue Apr 03 23:19:55 2018 SmartLock: Run the IO thread on mainloop instead of a real thread. This fixes a crashing test (with DCHECK enabled) caused by the IO thread having a different ID for each test. This conflicted with the constraint of the NSSInitSingleton that its methods be called with thread-affinity (on the same thread ID). R=khorimoto@chromium.org Bug: 828538 Test: EasyUnlockTpmKeyManagerTest.* Change-Id: I7936ed9ad09884a47a898344a99977d3d5d013ac Reviewed-on: https://chromium-review.googlesource.com/994071 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#547863} [modify] https://crrev.com/cf3ff80ba71e29d522158628a3cced1f9d2e0f2b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc
,
Apr 3 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jhawkins@chromium.org
, Apr 3 2018