2D UI - Permission Indicator - Downloading ... toast is drawn over Permissions indicators. |
|||
Issue descriptionChrome Version: 67.0.3384.0 OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? Testcase: Allow Auto download Permission request (1) Set up Chrome to run permission request test cases (2) Access https://permission.site/ on the test device. (3) Enter Chrome VR (4) Click “Auto Download” button (5) Click “Allow” button (5) Click Download on the popup dialog at the bottom of the screen. What is the expected result? The "Downloaing..." toast should appear on the screen in an appropriate location, also the color should match that of the Permission Indicator hover tooltips/toasts. Moving to the same location as the Permission Indicator hover toasts might be an option but would require either disabling the Permission Indicator hover functionality while the "Downloading..." toast is present or causing it to be dismissed early to allow the Permission indicator to show. What happens instead? Currently the toast is on top of the Permission Indicators at the top of the screen.
,
Apr 5 2018
,
Apr 5 2018
For now, we'll place the toast slightly below the content window. If it's updated in the future to respect the gravity of the Android toast it's representing, we'll have to address this indicator overlap issue again.
,
Apr 6 2018
Update: It's over content, toward the bottom, but slightly above where the corresponding Download snackbar appears.
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/656cb984996eb626fcc2c123d201d57c81ecba34 commit 656cb984996eb626fcc2c123d201d57c81ecba34 Author: Christopher Grant <cjgrant@chromium.org> Date: Fri Apr 06 15:05:03 2018 VR: Move platform toast toward the bottom of the content This change puts the toast over content, near the bottom, in a position just above where a downloading snackbar appears. It also removes the linear layout that previously held more than one toast. BUG= 828515 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iab15c457261e9887940c69140c9af607eb18f1cd Reviewed-on: https://chromium-review.googlesource.com/998404 Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#548776} [modify] https://crrev.com/656cb984996eb626fcc2c123d201d57c81ecba34/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/656cb984996eb626fcc2c123d201d57c81ecba34/chrome/browser/vr/ui_scene_creator.cc
,
Apr 6 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bshe@chromium.org
, Apr 3 2018