Add build properties to parameters json input to Buildbucket |
||||
Issue descriptionThis is a build with full parameter information (e.g, build config, branch) https://apis-explorer.appspot.com/apis-explorer/?base=https://cr-buildbucket.appspot.com/_ah/api#p/buildbucket/v1/buildbucket.get?id=8950245895045049568&_h=1& And this is a build without the full parameter information, which makes it hard to parse what's its build config (I can also iterate through the tags, but the tags should ideally only be used for searching) https://apis-explorer.appspot.com/apis-explorer/?base=https://cr-buildbucket.appspot.com/_ah/api#p/buildbucket/v1/buildbucket.get?id=8950247927680978432&_h=1& The builder groups that I noticed are missing properties are: firmware, factory and utility.
,
Apr 3 2018
If this happens, the fault is not in Legoland. Just let it break, though filing bugs to me is handy. ;> "link-depthcharge-full-firmware" is the build config in question.
,
Apr 3 2018
Oh... looking at the config, I must not have added properties to the luci-scheduler configs, only tags. All builds scheduled that way will have the same issues.
,
Apr 4 2018
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ae89c8a3ce09989ed45e7aedaaaca254e1d3425c commit ae89c8a3ce09989ed45e7aedaaaca254e1d3425c Author: Don Garrett <dgarrett@google.com> Date: Thu Apr 05 00:50:46 2018 luci-scheduler: Include properties. All tags should also be listed as properties. Further, we should always explicitly set "cbb_extra_args". BUG= chromium:828512 TEST=None Change-Id: If7ecd4bb3e03d30c18b95e1d93346c2bf01339a5 Reviewed-on: https://chromium-review.googlesource.com/996529 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/ae89c8a3ce09989ed45e7aedaaaca254e1d3425c/luci-scheduler.cfg
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ec5d3a0780e5392fdcdb0b33ff6eeae700db604e commit ec5d3a0780e5392fdcdb0b33ff6eeae700db604e Author: Don Garrett <dgarrett@google.com> Date: Thu Apr 05 01:13:35 2018 luci-scheduler: Fix a syntax error. Also, add a PRESUBMIT for verify configs. Can only be used with "git cl upload". BUG= chromium:828512 Change-Id: Ic63d94ae4b3ed3724a612e973bac5760c61ff93f Reviewed-on: https://chromium-review.googlesource.com/996923 Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> [add] https://crrev.com/ec5d3a0780e5392fdcdb0b33ff6eeae700db604e/PRESUBMIT.py [modify] https://crrev.com/ec5d3a0780e5392fdcdb0b33ff6eeae700db604e/luci-scheduler.cfg
,
Apr 5 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dgarr...@chromium.org
, Apr 3 2018