New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 828510 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 809021
issue 809165



Sign in to add a comment

MediaQueryParser::IsMediaFeatureAllowedInMode returns false even when parsing a UA stylesheet

Project Member Reported by steimel@chromium.org, Apr 3 2018

Issue description

MediaQueryParser::IsMediaFeatureAllowedInMode always returns false for the "immersive" media query, even when parsing a UA stylesheet
 
Blocking: 809021
I have a WIP patch that does, I think, plumb the CSS parser mode [1]. I'm still not seeing media controls change with it applied, however. I also tried forcing a crash whenever we queried whether the immersive media feature is enabled, and it was never tripped. It does look like your CL has landed, though [2]. Am I doing something wrong?

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1002152
[2] https://chromium-review.googlesource.com/c/chromium/src/+/993396
Do you have modern media controls enabled?
I did not, embarrassingly. :)

With my patch, we do indeed parse the new immersive controls scheme, BUT we always apply the immersive styles and I'm not sure why that is. I have a test page which changes color in and out of immersive mode, and it works correctly (if I hack up the code to ignore the UA stylesheet restriction, of course), but we don't seem to reevaluate in this case. Still looking into why..
Blocking: 809165

Comment 6 by ddorwin@chromium.org, Jan 18 (4 days ago)

Labels: OS-Android

Comment 7 by samdrazin@chromium.org, Today (16 hours ago)

Labels: VR-B-Media
Owner: ----

Sign in to add a comment