New issue
Advanced search Search tips

Issue 828508 link

Starred by 1 user
Status: Fixed
Owner:
agrieve@chromium.org
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

AndroidManifext.xml is not hermetic in our builds

Project Member Reported by agrieve@chromium.org, Apr 3 2018 
Noticed that on a 64-bit apk vs a 32-bit one that entries from manifest merging are not always ending up in the same spots (img attached of a diff of aapt dump xmltree Foo.apk AndroidManifest.xml)
Screen Shot 2018-04-03 at 2.03.42 PM.png
198 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/081ead710ebc4645053c6bf3ef0a00bb36d50a3c

commit 081ead710ebc4645053c6bf3ef0a00bb36d50a3c
Author: Andrew Grieve <agrieve@chromium.org>
Date: Wed Apr 04 18:19:45 2018

Android: Maintain original order of sibling deps within .build_configs

This reduces randomness in the build by making our dependency
sorting a stable sort.

Bug:  828528 ,  828508 
Change-Id: Ibf0f1de0d77333cdee575560912728e47b8f292e
Reviewed-on: https://chromium-review.googlesource.com/994545
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548131}
[modify] https://crrev.com/081ead710ebc4645053c6bf3ef0a00bb36d50a3c/build/android/PRESUBMIT.py
[modify] https://crrev.com/081ead710ebc4645053c6bf3ef0a00bb36d50a3c/build/android/gyp/util/build_utils.py
[add] https://crrev.com/081ead710ebc4645053c6bf3ef0a00bb36d50a3c/build/android/gyp/util/build_utils_test.py
[modify] https://crrev.com/081ead710ebc4645053c6bf3ef0a00bb36d50a3c/build/android/gyp/write_build_config.py
[modify] https://crrev.com/081ead710ebc4645053c6bf3ef0a00bb36d50a3c/build/android/gyp/write_ordered_libraries.py

Comment 2 by agrieve@chromium.org, Apr 5 2018

Status: Fixed (was: Available)
►

Sign in to add a comment