New issue
Advanced search Search tips

Issue 828489 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task



Sign in to add a comment

[Component Request] infra>autoroller-audit

Project Member Reported by bore...@google.com, Apr 3 2018

Issue description

1] Component Name: infra>autoroller-audit

Guideline 1 (Clarity): Component name should be descriptive beyond the core
project team
(i.e. please avoid using non-industry standard abbreviations, code words,
project names, etc...)

Guideline 2 (Permanence): Component names should describe features/
functions and not team names, code locations, etc..., which are more
subject to change and make the hierarchy less predictable for people
triaging issues.

Guideline 3 (Specific): Components are meant to explicitly track functional
work areas.  If you are trying to track a Proj(ect) or an on-going effort
(e.g. Hotlist-Conops), please instead request a label for a (Proj- or
Hotlist-)

Guideline 4 (Discoverable/ Predictable): Components should be parented
where people would logically expect to find them (i.e. follow product
decomposition when naming versus team decomposition)

2] Parent Component (e.g. Blink, UI>Browser, etc...): Infra

Note: We generally avoid creating new component namespaces, unless there is
a new hierarchy that needs to be expressed.  Please try and use existing
components as parents.

3] Description of Component: High-priority bugs filed by the Audit App when AutoRollers are misbehaving (eg. compromised accounts).

4] Admin/ Owner: borenet@, skiabot@, robertocn@, stgao@

5] Please specify what triage practices will be followed for the component
(i.e. what team will do it and how frequently).

Skia Infra team (skiabot@) will triage bugs.  They should all be high priority and fixed quickly.



 

Comment 1 by st...@chromium.org, Apr 3 2018

IMHO, robertocn@ and stgao@ don't have to be the admin/owner here, as the bugs filed for violations is on the auto-roller side.
If it turns out to be a bug on audit-app side, please do feel free to pass over the bug to robertocn@ or me.
Labels: Pri-1 Type-Task

Comment 3 by efoo@chromium.org, Apr 11 2018

Cc: dpranke@chromium.org
Owner: efoo@chromium.org
Status: Assigned (was: Untriaged)
I am hesitate to create this since the request asked for a top-level Infra component. 

I would suggest Infra>AutoRoller>Audit or even under another component under Infra (if one aligns).

Please confirm before I create the component. +dpranke for visibility. 

Comment 4 by st...@chromium.org, Apr 11 2018

As inspired by efoo@, an alternative is the reverse: Infra>Audit>AutoRoller.

Findit team could own Infra>Audit as for the Audit-App (we don't have a dedicate component for it, and we use Tools>Test>FindIt to cover it so far. That works but seems not best.), while borenet@ (and skia team) could own Infra>Audit>AutoRoller as for bugs in the auto-roller detected by the Audit-App.

Comment 5 by bore...@google.com, Apr 11 2018

Infra>Audit>AutoRoller SGTM.  I just want to make it clear that it's not the right place for general autoroller bugs (which should fall under the Skia project).

Comment 6 by st...@chromium.org, Apr 11 2018

Re #5: we could make it clear in the component description where to file AutoRoller bugs.

Infra>Audit:
Description: Bugs and feature requests for Audit App.
cc rule: robertocn@, stgao@

Infra>Audit>AutoRoller:
Description: Audit Rule violation for auto-roller. Please file general autoroller bugs under Skia project instead.
cc rule: borenet@, skiabot@


borenet@, effo@, dpranke@: what do you think of above?

Comment 7 by bore...@google.com, Apr 11 2018

All of that SGTM

Comment 8 by efoo@chromium.org, Apr 12 2018

Status: Fixed (was: Assigned)
sgtm. Created new components and marked as fixed. 

Only thing that I excluded is CCing skiabot@google.com since that is an internal address. Infra>Audit>AutoRoller bugs will still cc borenet@chromium.org. Let me know if a different address should be added. 

Sign in to add a comment