High Precision input for nacl. |
||||||||
Issue descriptionNacl input events are still rounded to integers. We should remove the rounding code and send high precision touch events to nacl.
,
Apr 3 2018
I think affected OS is every OS. Please correct me if it's wrong. Will leave the milestone to Tom.
,
Apr 3 2018
This bug requires manual review: Less than 10 days to go before AppStore submit on M66 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 3 2018
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5f13bd660bca233981eb4e17e5851cb4e15f6ab commit e5f13bd660bca233981eb4e17e5851cb4e15f6ab Author: Jingkui Wang <jkwang@google.com> Date: Tue Apr 03 22:01:46 2018 High Precision Input for Nacl Remove the code rounding nacl input event to integers. BUG= chromium:828486 Change-Id: Icd60c7c8e133e8bd0143712a779feb24059ac62d Reviewed-on: https://chromium-review.googlesource.com/993152 Commit-Queue: Jingkui Wang <jkwang@google.com> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#547845} [modify] https://crrev.com/e5f13bd660bca233981eb4e17e5851cb4e15f6ab/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.cpp
,
Apr 4 2018
Can you add the rationale regarding this merge?
,
Apr 4 2018
Right now, input points in web plugins (eg. NaCl) are rounded despite being stored in floats. Removing this rounding is critical to support low-latency inking in Google Keep, which is important to Chrome OS given that Keep is the default note-taking app and we have publicized our latency at events like the Pixelbook launch.
,
Apr 5 2018
We only have one beta cycle left before M66 goes out to stable. Though the fix seems fairly small, What is your confidence level regarding the overall risk associated with merging this cl into M66?
,
Apr 5 2018
I am quite confident the risk is low. As all of the stacks are already dealing with floats. This change only results in a different value. The only incompatibility it would cause is: someone explicitly checks if a float was actually rounded to an integer. I could not imagine anyone does this. With that said, I am glad to learn if anyone else has other concerns.
,
Apr 6 2018
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92616da07c7cbb5a3ff7c419ca3d94c187750428 commit 92616da07c7cbb5a3ff7c419ca3d94c187750428 Author: Jingkui Wang <jkwang@google.com> Date: Fri Apr 06 15:14:56 2018 High Precision Input for Nacl Remove the code rounding nacl input event to integers. BUG= chromium:828486 Change-Id: Icd60c7c8e133e8bd0143712a779feb24059ac62d Reviewed-on: https://chromium-review.googlesource.com/993152 Commit-Queue: Jingkui Wang <jkwang@google.com> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#547845}(cherry picked from commit e5f13bd660bca233981eb4e17e5851cb4e15f6ab) Reviewed-on: https://chromium-review.googlesource.com/998174 Cr-Commit-Position: refs/branch-heads/3359@{#604} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/92616da07c7cbb5a3ff7c419ca3d94c187750428/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.cpp
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5134599de78ce2c5444afc0be5323e9f8658ade7 commit 5134599de78ce2c5444afc0be5323e9f8658ade7 Author: Jingkui Wang <jkwang@google.com> Date: Fri Apr 06 22:52:11 2018 Revert "High Precision Input for Nacl" This reverts commit 92616da07c7cbb5a3ff7c419ca3d94c187750428. Reason for revert: Breaks official.android on 3359: crbug.com/830058 Original change's description: > High Precision Input for Nacl > > Remove the code rounding nacl input event to integers. > > BUG= chromium:828486 > > Change-Id: Icd60c7c8e133e8bd0143712a779feb24059ac62d > Reviewed-on: https://chromium-review.googlesource.com/993152 > Commit-Queue: Jingkui Wang <jkwang@google.com> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#547845}(cherry picked from commit e5f13bd660bca233981eb4e17e5851cb4e15f6ab) > Reviewed-on: https://chromium-review.googlesource.com/998174 > Cr-Commit-Position: refs/branch-heads/3359@{#604} > Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} TBR=dtapuska@chromium.org,jkwang@google.com Change-Id: Iac30f222b8e9dd832032f18afd6e27a9716004a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:828486 Reviewed-on: https://chromium-review.googlesource.com/1000592 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#608} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/5134599de78ce2c5444afc0be5323e9f8658ade7/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.cpp
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ae132bd4b9ef4e5733b8ef7fb53ca48dc1dc636 commit 3ae132bd4b9ef4e5733b8ef7fb53ca48dc1dc636 Author: Jingkui Wang <jkwang@google.com> Date: Mon Apr 09 18:45:49 2018 High Precision Input for Nacl Remove the code rounding nacl input event to integers. BUG= chromium:828486 Reviewed-on: https://chromium-review.googlesource.com/993152 Commit-Queue: Jingkui Wang <jkwang@google.com> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#547845} Change-Id: Id44e8f24177389a366f9c1b649fa9274bdd2c388 Reviewed-on: https://chromium-review.googlesource.com/1000791 Cr-Commit-Position: refs/branch-heads/3359@{#626} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/3ae132bd4b9ef4e5733b8ef7fb53ca48dc1dc636/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.cpp [modify] https://crrev.com/3ae132bd4b9ef4e5733b8ef7fb53ca48dc1dc636/third_party/WebKit/public/platform/WebPointerProperties.h
,
Apr 19 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by gkihumba@google.com
, Apr 3 2018