New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 828482 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Handle H264 h/w encoders that do not support packed headers

Project Member Reported by ddavenp...@chromium.org, Apr 3 2018

Issue description

Chrome will always send the packed header and slice data to encoders, but some encoders do not support packed headers.
 
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62a0b27763707842e3388bfa2663b87018657b49

commit 62a0b27763707842e3388bfa2663b87018657b49
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Thu Apr 12 06:27:14 2018

media/gpu/vaapi: Disable H264 HW encode and MJPEG decode on StoneyRidge

BUG=b:76445849,  chromium:828119 ,  chromium:828482
TEST=jpeg_decode_accelerator_unittest and video_encode_accelerator_unittest on StoneyRidge device

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifa61026390fe31e88e0929257a521745e9a72fad
Reviewed-on: https://chromium-review.googlesource.com/983334
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550049}
[modify] https://crrev.com/62a0b27763707842e3388bfa2663b87018657b49/media/gpu/vaapi/va.sigs
[modify] https://crrev.com/62a0b27763707842e3388bfa2663b87018657b49/media/gpu/vaapi/vaapi_wrapper.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cfbc0db38b615cef3fd82ad321673e7e262796a8

commit cfbc0db38b615cef3fd82ad321673e7e262796a8
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Fri Apr 13 06:10:56 2018

avtest_label_detect: Disable HW H264 encoding and JPEG decoding on AMD StoneyRidge

Chrome doesn't support HW H264 encoding and JPEG decoding on AMD StoneyRidge
because of https://crbug.com/828482 and  https://crbug.com/828119 .

BUG=b:76445849, b:77499495,  chromium:828119 , chromium:828482
TEST=avtest_label_detect

Change-Id: Ic8a8b7839df8604cf423772ccb4c8db0f65fd7b4
Reviewed-on: https://chromium-review.googlesource.com/1004078
Commit-Ready: Hirokazu Honda <hiroh@chromium.org>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Tested-by: Deepak Sharma <deepak.sharma@amd.com>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Deepak Sharma <deepak.sharma@amd.com>

[modify] https://crrev.com/cfbc0db38b615cef3fd82ad321673e7e262796a8/avtest_label_detect/util_vaapi.c

Comment 4 by djkurtz@google.com, May 31 2018

Cc: kcwu@chromium.org mcasas@chromium.org
Owner: hiroh@chromium.org
Status: Assigned (was: Available)
Hiroh, What is that status for this one?  Are all patches landed now, or is there more work to do?
Components: -Internals>GPU>Video OS>Kernel>Video
Owner: posciak@chromium.org
Components: Internals>GPU>Video
Component OS>Kernel>Video is for work implying (in all likelihood) non-Chromium repo
  code, e.g. mesa, libva etc. It is not tantamount to ChromeOS specific, since for 
  that we just have OS:Chrome. For personal or team bug classification there are 
  other ways such as Labels or, preferrably, Hotlists.

Internals>GPU>Video is for work that is likely going to imply Chromium code work in
  areas e.g. //media/gpu/*, //ui/gfx, etc.  When complemented with OS:ChromeOS and
  e.g. GPU=Intel, it refers to intel chromebooks etc.

With this, I'm restoring the Internals>GPU>Video since #2 makes me believe Chromium
side work will be needed.
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment