New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 828473 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

NavigationMojoResponse on WebView Beta.

Project Member Reported by arthurso...@chromium.org, Apr 3 2018

Issue description

I prepare a patch, it enables NavigationMojoReponse on M66 Beta.
https://chromium-review.googlesource.com/c/chromium/src/+/993092

There is one known issue on Android WebView:
 https://crbug.com/828156 

From our discussion in the meeting, we may still want to enable it on M66 beta for WebView (the other platforms are controlled using Finch). The goal is to know whether there are new bugs or not.

+CC nasko@. Depending on the results of   https://crbug.com/822650  , I will let you choose if we really want to request a merge for M66 Beta to catch new bugs.
 

Comment 1 by nasko@chromium.org, Apr 3 2018

If we can fix the WebView test issue, I think we should attempt M66 beta this week so we can see if there are any further WebView issues we have not hit yet.

The fix for  issue 822650  was just merged, so we are clear for M66 platforms that use Finch, so we are left only with WebView. 
The patch has been merged in M66. The patch was associated with  issue 705744 . I copy the commit message here:
_______

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/155372c15ae6c39f1fa004e8be2294fe3d4fd6f3

commit 155372c15ae6c39f1fa004e8be2294fe3d4fd6f3
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Tue Apr 03 21:52:30 2018

NavigationMojoResponse: Enable by default [M66 merge]

Launch bug: https://crbug.com/805851
Design doc: https://goo.gl/Rrrc7n

TBR=arthursonzogni@chromium.org

(cherry picked from commit 35bdafcc9cba142b9a45d91abbc71d0c34694e2a)

Bug:  705744 
Change-Id: If959163cdafc49913edccbca980179aa5e97ef21
Reviewed-on: https://chromium-review.googlesource.com/852094
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#547350}
Reviewed-on: https://chromium-review.googlesource.com/993092
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#566}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/155372c15ae6c39f1fa004e8be2294fe3d4fd6f3/content/public/common/content_features.cc
Description: Show this description
Status: Fixed (was: Assigned)

Sign in to add a comment