New issue
Advanced search Search tips

Issue 828457 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
kojii@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

line-height quirk does not work when a collapsible space followed by <br>

Project Member Reported by kojii@chromium.org, Apr 3 2018 
The line-height quirk:
  https://quirks.spec.whatwg.org/#the-line-height-calculation-quirk
defines that if:

  It either contains no text or it contains only collapsed whitespace.

then the line-height quirk should be applied.

Blink and WebKit apply the line-height quirk for the first 3 cases below but not the last one.

  <div><img src="images/1x1.png"></div>
  <div><img src="images/1x1.png"> </div>
  <div><img src="images/1x1.png"><br></div>
  <div><img src="images/1x1.png"> <br></div>

Comment 1 by kojii@chromium.org, Apr 3 2018

line-height-qurik.html
350 bytes View Download

Comment 2 by kojii@chromium.org, Apr 3 2018 

Happens with <span> too.

  <div><span>text</span></div>
  <div><span>text</span> </div>
  <div><span>text</span><br></div>
  <div><span>text</span> <br></div>

Edge and Gecko render these 4 the same way.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbb1ce2222c42b9f4d083b90158709a55fe5334e

commit cbb1ce2222c42b9f4d083b90158709a55fe5334e
Author: Koji Ishii <kojii@chromium.org>
Date: Wed Apr 04 03:23:50 2018

Make overflow-border-radius* tests to standard mode

These 4 tests:
  fast/clip/overflow-border-radius-combinations.html
  fast/clip/overflow-border-radius-composited.html
  fast/clip/overflow-border-radius-composited-parent.html
  fast/clip/overflow-border-radius-transformed.html
hit a bug in Blink where it fails to apply line-height quirks
as described in crbug.com/828457, and that they fail in LayoutNG
which applies line-height quirks.

https://quirks.spec.whatwg.org/#the-line-height-calculation-quirk

Because these tests are not important for testing the line-height
quirks, this patch changes them to the standard mode so that they
do not hit the bug.

Rebaselines are not needed, because the line-height quirks are
not applied to the expected images.

Bug: 828457
Change-Id: Ic6ad43996210e64a366f521db789d96857ee3108
Reviewed-on: https://chromium-review.googlesource.com/993112
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547969}
[modify] https://crrev.com/cbb1ce2222c42b9f4d083b90158709a55fe5334e/third_party/WebKit/LayoutTests/fast/clip/overflow-border-radius-combinations.html
[modify] https://crrev.com/cbb1ce2222c42b9f4d083b90158709a55fe5334e/third_party/WebKit/LayoutTests/fast/clip/overflow-border-radius-composited-parent.html
[modify] https://crrev.com/cbb1ce2222c42b9f4d083b90158709a55fe5334e/third_party/WebKit/LayoutTests/fast/clip/overflow-border-radius-composited.html
[modify] https://crrev.com/cbb1ce2222c42b9f4d083b90158709a55fe5334e/third_party/WebKit/LayoutTests/fast/clip/overflow-border-radius-transformed.html
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23a349ca9756d38e7a93e543d9482643597c5a62

commit 23a349ca9756d38e7a93e543d9482643597c5a62
Author: Koji Ishii <kojii@chromium.org>
Date: Wed Apr 04 08:11:30 2018

Change float/color-correction/file-url tests to standard mode

Following CL:993112, these 4 tests are also affected by the
line-height quirks bug.
  fast/block/float/float-in-float-hit-testing.html
  fast/block/float/float-in-float-painting.html
  fast/css/color-correction-on-backgrounds.html
  http/tests/local/file-url-sent-as-referer.html

2 of them require rebaseline, because of the layout change in
other parts.

Bug: 828457
Change-Id: Ifab5b4d096277fc48c04bdff21318fd86405cec8
Reviewed-on: https://chromium-review.googlesource.com/992972
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548004}
[modify] https://crrev.com/23a349ca9756d38e7a93e543d9482643597c5a62/third_party/WebKit/LayoutTests/fast/block/float/float-in-float-hit-testing.html
[modify] https://crrev.com/23a349ca9756d38e7a93e543d9482643597c5a62/third_party/WebKit/LayoutTests/fast/block/float/float-in-float-painting.html
[modify] https://crrev.com/23a349ca9756d38e7a93e543d9482643597c5a62/third_party/WebKit/LayoutTests/fast/css/color-correction-on-backgrounds.html
[modify] https://crrev.com/23a349ca9756d38e7a93e543d9482643597c5a62/third_party/WebKit/LayoutTests/http/tests/local/file-url-sent-as-referer.html
[modify] https://crrev.com/23a349ca9756d38e7a93e543d9482643597c5a62/third_party/WebKit/LayoutTests/platform/linux/fast/css/color-correction-on-backgrounds-expected.png
[modify] https://crrev.com/23a349ca9756d38e7a93e543d9482643597c5a62/third_party/WebKit/LayoutTests/platform/linux/fast/css/color-correction-on-backgrounds-expected.txt
[modify] https://crrev.com/23a349ca9756d38e7a93e543d9482643597c5a62/third_party/WebKit/LayoutTests/platform/linux/http/tests/local/file-url-sent-as-referer-expected.txt
[modify] https://crrev.com/23a349ca9756d38e7a93e543d9482643597c5a62/third_party/WebKit/LayoutTests/platform/mac/fast/css/color-correction-on-backgrounds-expected.png
[modify] https://crrev.com/23a349ca9756d38e7a93e543d9482643597c5a62/third_party/WebKit/LayoutTests/platform/mac/fast/css/color-correction-on-backgrounds-expected.txt
[modify] https://crrev.com/23a349ca9756d38e7a93e543d9482643597c5a62/third_party/WebKit/LayoutTests/platform/mac/http/tests/local/file-url-sent-as-referer-expected.txt
[modify] https://crrev.com/23a349ca9756d38e7a93e543d9482643597c5a62/third_party/WebKit/LayoutTests/platform/win/fast/css/color-correction-on-backgrounds-expected.png
[modify] https://crrev.com/23a349ca9756d38e7a93e543d9482643597c5a62/third_party/WebKit/LayoutTests/platform/win/fast/css/color-correction-on-backgrounds-expected.txt
[modify] https://crrev.com/23a349ca9756d38e7a93e543d9482643597c5a62/third_party/WebKit/LayoutTests/platform/win/http/tests/local/file-url-sent-as-referer-expected.txt

Comment 5 by e...@chromium.org, Aug 20

Labels: Fixed-In-LayoutNG
►

Sign in to add a comment