New Tools Menu strings have line breaks when translation is long |
|||||||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): M67 iOS Version: All Device: iPhone SE Steps to reproduce: 1.) Switch language to Ukrainian 2.) Enable UI refresh flag 3.) Open Tools menu Observed behavior: Menu items have line-breaks Expected behavior: Each item should take only one row
,
Apr 3 2018
Should we make the toolbar wider if strings do not fit? It's just feels unpolished to have room for strings, and break the lines instead of resizing the menu. On the other hand I don't know how many languages will have this problem, so maybe this is not a big deal.
,
Apr 3 2018
The popup is able to grow up to 300pt wide (you are using an old version of canary, so maybe it is slightly smaller on yours). The old tools menu has barely enough space to fit all the strings in one line, and we have an image to take into account here. The image would probably prevent the translation for fitting on one line.
,
Apr 3 2018
Thanks. For comparison, the old menu was able to fit all strings. But it looks better with the latest canary (only Report a Problem does not fit the menu). iPhone SE screen is pretty small. Are we going to have wider menu on bigger phones?
,
Apr 3 2018
For now the max width is 300 for all devices. +mardini if you have an opinion.
,
Apr 3 2018
I think the screenshot titled "IMG_5785.PNG" is as wide as the menu should be. It shouldn't cover the whole screen. Is that the 300 pt you are referring to?
,
Apr 3 2018
Yes 5785 is the 300pt on an iPhone SE. Here is a screen shot on an iPhone 8+ (still 300pt). Eugene: I needed to increase the font to have it spread over two lines. Did you increase the the fonts on your device?
,
Apr 3 2018
I see. Thanks. I guess on bigger phones it makes sense to make it a big bigger if needed. Instead of having the popup's max width be an absolute value, shouldn't it be an offset from the screen edge? i.e. always leave x pt between end of popup and screen edge.
,
Apr 3 2018
I did not increase the Font size on my device. If line breaking only happens on small devices with a few languages, then we probably should not bother. I agree with comment #8. Making menu wider if needed seems reasonable.
,
Apr 4 2018
,
Apr 4 2018
,
Apr 4 2018
,
Apr 6 2018
,
Apr 6 2018
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37c61722aebab5393b4e77999ec103c69d706278 commit 37c61722aebab5393b4e77999ec103c69d706278 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Apr 18 15:03:58 2018 Adjust PopupMenu width constraints This CL adjusts the width constraints of the popup menus, allowing the menu to grow bigger on phone having bigger screens, but make sure there is enough space to dismiss the menu on smaller screens. Bug: 828433 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I38fd6f7a1842ef50aa5df2ee50fbfb6b54fd9d86 Reviewed-on: https://chromium-review.googlesource.com/1013712 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551676} [modify] https://crrev.com/37c61722aebab5393b4e77999ec103c69d706278/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.mm
,
Apr 18 2018
,
Apr 24 2018
Verified in: App Version: 68.0.3405.0 canary Devices: iPhone 7, iPhone SE, iPhone 8 Plus iOS Versions: 10.3.3, 11.2.6, 11.4 beta 2 Popup or Tools menu items are displayed as per the screenshots attached in comment#4 & #7. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by gambard@chromium.org
, Apr 3 2018