New issue
Advanced search Search tips

Issue 828429 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Cannot close Chrome app window with double click in top left corner

Project Member Reported by wfh@chromium.org, Apr 3 2018

Issue description

Chrome Version: 67.0.3387.0 (Official Build) canary (64-bit) (cohort: Clang-64)
OS: Windows 10 build 1607 (14393.2068)

What steps will reproduce the problem?
(1) Open a chrome app e.g. Secure Shell App pnhechapfaindjhompbnflcldabbghjo in a window
(2) double click on top left corner
(3)

What is the expected result?

Window closes

What happens instead?

Nothing happens.

Please use labels and text to provide additional information.

This is fine in Stable M65.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 by wfh@chromium.org, Apr 3 2018

Cc: bsep@chromium.org
Components: UI

Comment 2 by wfh@chromium.org, Apr 3 2018

this happens to all windows without a tabstrip e.g. following javascript:

window.open('chrome://blank', 'blank', 'width=300,height=300');

cannot be closed by double-clicking on the top left of the window.

Comment 3 by bsep@chromium.org, Apr 3 2018

Cc: -bsep@chromium.org
Owner: bsep@chromium.org
Status: Assigned (was: Untriaged)
We are talking about removing that for main chrome windows, but I think if there is a window icon it should be consistent with other Windows window icons. So I will fix this.
Alternative repro is to use

  chrome.exe --app=https://mail.google.com

Notably, if you click *to the left* of the icon (red box in the attached screenshot), the system menu properly activates (and double-click closes the Chrome Window).

In other Windows applications, and Chrome 67 before the recent custom title bar change, clicking in the icon (green box in the attached screenshot) invokes the system menu, and double-click closes the Chrome Window.

> We are talking about removing that for main chrome windows

FWIW, breaking consistency with two decades of Windows behavior would make me sad. 
ClickTargets.png
3.4 KB View Download
Labels: FoundIn-67
Summary: Cannot close Chrome app window with double click in top left corner (was: cannot close chrome app window with double click in top left corner)
This regression also impacts undocked DevTools windows.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d969695fcd4ef5a32925f760b909adc891ba90f

commit 0d969695fcd4ef5a32925f760b909adc891ba90f
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Apr 13 01:57:28 2018

Fix system menu not appearing when clicking the corner of popup windows.

On Windows the system menu is expected to appear on a single left-click
to the top-left corner of the window, and a double click is expected to
close the window. The Views window icon added by custom titlebar was
intercepting the click and so the WM_NCLBUTTONDOWN message was not
getting DefWindowProc'ed. This patch fixes this by disabling event
handling on that icon, as it isn't supposed to do anything.

Bug:  828429 
Change-Id: I1ee0cfe38707479948b51eed48da83639964a7ae
Reviewed-on: https://chromium-review.googlesource.com/1011544
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550472}
[modify] https://crrev.com/0d969695fcd4ef5a32925f760b909adc891ba90f/chrome/browser/ui/views/frame/glass_browser_frame_view.cc

Comment 7 by bsep@chromium.org, Apr 13 2018

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d969695fcd4ef5a32925f760b909adc891ba90f

commit 0d969695fcd4ef5a32925f760b909adc891ba90f
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Apr 13 01:57:28 2018

Fix system menu not appearing when clicking the corner of popup windows.

On Windows the system menu is expected to appear on a single left-click
to the top-left corner of the window, and a double click is expected to
close the window. The Views window icon added by custom titlebar was
intercepting the click and so the WM_NCLBUTTONDOWN message was not
getting DefWindowProc'ed. This patch fixes this by disabling event
handling on that icon, as it isn't supposed to do anything.

Bug:  828429 
Change-Id: I1ee0cfe38707479948b51eed48da83639964a7ae
Reviewed-on: https://chromium-review.googlesource.com/1011544
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550472}
[modify] https://crrev.com/0d969695fcd4ef5a32925f760b909adc891ba90f/chrome/browser/ui/views/frame/glass_browser_frame_view.cc

Comment 9 by bsep@chromium.org, Jun 14 2018

Cc: bsep@chromium.org
 Issue 852245  has been merged into this issue.

Sign in to add a comment