Web Animations: Document::getAnimations should exclude animations whose target is not in the document |
||
Issue descriptionCurrently we include all listed Animations, even if they have a null target or a target outside the Document. This is against spec: https://drafts.csswg.org/web-animations-1/#dom-document-getanimations """Returns the set of Animation objects that have an associated target effect which is current or in effect and whose target element is a descendant of the document.""" Should be an easy fix.
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81d741b16775f616385e0f4b65fcf94d6beaeae1 commit 81d741b16775f616385e0f4b65fcf94d6beaeae1 Author: Stephen McGruer <smcgruer@chromium.org> Date: Wed Apr 04 19:31:59 2018 Web Animations: Fix bug with Document::getAnimations Per spec, we should exclude effects that do not target an element in the called document: https://drafts.csswg.org/web-animations-1/#dom-document-getanimations Bug: 828424 Change-Id: I41405d82184b17c1185931e34735a5f946573844 Reviewed-on: https://chromium-review.googlesource.com/992812 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#548156} [delete] https://crrev.com/c5266e44d815408fbb6d258d96a629e37ee817a5/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Document/getAnimations-expected.txt [modify] https://crrev.com/81d741b16775f616385e0f4b65fcf94d6beaeae1/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Document/getAnimations.html [modify] https://crrev.com/81d741b16775f616385e0f4b65fcf94d6beaeae1/third_party/WebKit/Source/core/animation/DocumentTimeline.cpp
,
Apr 4 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by smcgruer@chromium.org
, Apr 3 2018