New issue
Advanced search Search tips

Issue 828405 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Dashboard - Deploy pushing stale version

Project Member Reported by simonhatch@chromium.org, Apr 3 2018

Issue description

Annie hit this recently, think we've seen this a couple times but sporadically with no reliable repro. Current theory is we're pushing stale pyc files, which might be why run_py_tests and purging pyc files fixes the issue. I thought the pyc files weren't deployed, but apparently they are:

https://cloud.google.com/appengine/docs/standard/python/runtime


Notably: "By default, .pyc files are skipped during deployment. You must override the skip_files element in your app.yaml file so that the new value does not cause .pyc files to be skipped."

We do override skip_files, so maybe we need to add the default filters back: https://cloud.google.com/appengine/docs/standard/python/config/appref#skip_files

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/d652069a14cdb0fba240f579e81ce386d7c08c55

commit d652069a14cdb0fba240f579e81ce386d7c08c55
Author: Simon <simonhatch@chromium.org>
Date: Tue Apr 03 15:23:21 2018

Dashboard - Add default filters back to skip_files.

The skip_files parameter in app.yaml has a whole bunch of defaults, so
when this was overridden we lost those. This may be the cause of random
deployments being stale, since we'd be pushing pyc files too.

https://cloud.google.com/appengine/docs/standard/python/config/appref#skip_files

Bug: chromium:828405
Change-Id: I00b9cabde8291a89582dfb527e89cac56d72e41c
Reviewed-on: https://chromium-review.googlesource.com/992633
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/d652069a14cdb0fba240f579e81ce386d7c08c55/dashboard/app.yaml

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/996e8691caeb6b7aeb0a00f76212af44cef5b30d

commit 996e8691caeb6b7aeb0a00f76212af44cef5b30d
Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Apr 03 20:31:25 2018

Roll src/third_party/catapult/ 29a751cec..1fcfd9b6d (2 commits)

https://chromium.googlesource.com/catapult.git/+log/29a751ceced1..1fcfd9b6d53d

$ git log 29a751cec..1fcfd9b6d --date=short --no-merges --format='%ad %ae %s'
2018-04-03 bsheedy Add start service functionality on Android
2018-04-03 simonhatch Dashboard - Add default filters back to skip_files.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:828190,chromium:828405


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I9315a557b61fd7e3028cd623a9839640bddd7215
Reviewed-on: https://chromium-review.googlesource.com/992863
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547811}
[modify] https://crrev.com/996e8691caeb6b7aeb0a00f76212af44cef5b30d/DEPS

Cc: -eakuefner@chromium.org

Sign in to add a comment