New issue
Advanced search Search tips

Issue 828404 link

Starred by 2 users
Status: Fixed
Owner:
agrieve@chromium.org
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Dump file isn't valid multipart-from-data if produced without firebase_app_id set

Reported by mlopat...@yandex-team.ru, Apr 3 2018 
Steps to reproduce the problem:
1. Build and install chrome_public_apk
2. Set --enable-crash-reporter-for-testing in the command-line
3. Go to chrome://crash to produce minidump
4. Pull minidump from device

What is the expected behavior?
The minidump file is a valid multipart/form-data according to RFC 2388.

What went wrong?
There is an empty part in the file (boundary line immediately followed by another one). This violates section 5.1 of RFC 2046: a part must contain at least a blank line. This also means that some multipart/from-data parses fail to parse the dump.

Did this work before? Yes 

Chrome version: 67.0.3388 (at 831eb55c9824a394f896d3666ccf0f67d28f58a7)  Channel: canary
OS Version: N/A
Flash Version: N/A

This was introduced with https://chromium-review.googlesource.com/906843

This is probably a low priority issue because downstream Chrome targets should have firebase_app_id set but silently producing an invalid file seems wrong anyway.
2d3dfcdd-7de5-49c3-eff61eb4-5eb827db.dmp13286.gz
96.9 KB Download

Comment 1 by dtapu...@chromium.org, Apr 6 2018

Owner: agrieve@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee6db2338bbfc06221b94d02083d157e50efedbd

commit ee6db2338bbfc06221b94d02083d157e50efedbd
Author: Andrew Grieve <agrieve@chromium.org>
Date: Mon Apr 09 19:12:21 2018

Android: Fix malformed minidump when firebase id isn't set

Bug:  828404 
Change-Id: Ie327e93f391376fd77cae2df998a921b4a9f0002
Reviewed-on: https://chromium-review.googlesource.com/1002873
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549237}
[modify] https://crrev.com/ee6db2338bbfc06221b94d02083d157e50efedbd/components/crash/content/app/breakpad_linux.cc

Comment 3 by agrieve@chromium.org, Apr 9 2018

Status: Fixed (was: Assigned)
Thanks for the detailed report!
►

Sign in to add a comment