New issue
Advanced search Search tips

Issue 828392 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Use a gclient DEPS hook to set up a simple chrome SDK environment

Project Member Reported by achuith@chromium.org, Apr 3 2018

Issue description

Fuchsia, Oculus, Android and others use a gclient DEPS hook to download their SDKs. We should do something similar for chromeos. 
 
Cc: steve...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d8ac1b4c1fe49b249575ed7d935fc533b720eb1

commit 9d8ac1b4c1fe49b249575ed7d935fc533b720eb1
Author: Benjamin Pastene <bpastene@chromium.org>
Date: Tue Apr 03 20:33:02 2018

Add a DEPS hook that fetches simplechrome artifacts when targetting cros

https://chromium-review.googlesource.com/c/chromium/tools/build/+/988694/
will turn it on for the simple chrome bots (Right now they invoke all of
gclient inside the chrome-sdk.)

Bug: 732531, 828392
Change-Id: I1f892970cd19fd8f64dcfb6615d3033301ac2fcb
Reviewed-on: https://chromium-review.googlesource.com/989235
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547812}
[modify] https://crrev.com/9d8ac1b4c1fe49b249575ed7d935fc533b720eb1/DEPS
[modify] https://crrev.com/9d8ac1b4c1fe49b249575ed7d935fc533b720eb1/build/.gitignore

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b828cce0084e5771291320e6f5c8aa46f6c7d42f

commit b828cce0084e5771291320e6f5c8aa46f6c7d42f
Author: Benjamin Pastene <bpastene@chromium.org>
Date: Fri Apr 06 18:12:46 2018

Don't download goma binaries during the cros-simplechrome DEPS hook.

Bug: 828392
Change-Id: Iddc8ad3d6501b981e39e6569c5e6e3dbfbed5e31
Reviewed-on: https://chromium-review.googlesource.com/998335
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548857}
[modify] https://crrev.com/b828cce0084e5771291320e6f5c8aa46f6c7d42f/DEPS

Sign in to add a comment