New issue
Advanced search Search tips

Issue 828382 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 0
Type: Task
Q2



Sign in to add a comment

Popup Menu: Add feature tracker to the popup menu

Project Member Reported by gambard@chromium.org, Apr 3 2018

Issue description

The feature tracker should be added to the popup menus.
 

Comment 1 by cmasso@google.com, Apr 5 2018

Labels: Pri-0
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c388f408f40661e2faba927ba1a8993f839cc759

commit c388f408f40661e2faba927ba1a8993f839cc759
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Apr 06 08:57:10 2018

Add feature tracker to the popup menu

This CL adds the feature tracker to display the "new" badge for the
reading list in the tools menu.

Bug:  828382 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifff04e7d6f1ad255759905e88a0a8faceb4d79ff
Reviewed-on: https://chromium-review.googlesource.com/997814
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548715}
[modify] https://crrev.com/c388f408f40661e2faba927ba1a8993f839cc759/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/c388f408f40661e2faba927ba1a8993f839cc759/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.h
[modify] https://crrev.com/c388f408f40661e2faba927ba1a8993f839cc759/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/c388f408f40661e2faba927ba1a8993f839cc759/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h
[modify] https://crrev.com/c388f408f40661e2faba927ba1a8993f839cc759/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/c388f408f40661e2faba927ba1a8993f839cc759/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment