Popup Menu: Special case when there are unseen unread items |
||||
Issue descriptionWhen there are unread reading list items that haven't been seen, a special color or effect might be applied to the badge. The color is still to be defined.
,
Apr 16 2018
,
Apr 16 2018
,
Apr 17 2018
Per offline discussion, it has been acted that the "unseen" state in the tools menu won't be done in UI Refresh. The tools menu button won't change color and the tools menu entry/badge won't change color.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b926fe9e867eed4b9fba5c403a0a80458fd00690 commit b926fe9e867eed4b9fba5c403a0a80458fd00690 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Apr 17 12:34:12 2018 Remove the unseen state in UI Refresh This CL removes the unseen state (in the tools menu button in the toolbar) when the UI Refresh flag is enabled. Bug: 828367 , 831134 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4446d5b4f2565f256e4fedb829a77e93295b0d00 Reviewed-on: https://chromium-review.googlesource.com/1014092 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551302} [modify] https://crrev.com/b926fe9e867eed4b9fba5c403a0a80458fd00690/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [modify] https://crrev.com/b926fe9e867eed4b9fba5c403a0a80458fd00690/ios/chrome/browser/ui/toolbar/buttons/toolbar_tools_menu_button.mm
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/950668ec9ebb69e439726de235df94cd839fe0ce commit 950668ec9ebb69e439726de235df94cd839fe0ce Author: Gauthier Ambard <gambard@chromium.org> Date: Tue May 22 14:54:53 2018 Add separator for TabGrid popup menu This CL adds a separator between the additive and destructive actions of the TabGrid popup menu. The separator is automatically added between sections, so this CL is putting the additive and destructive actions in two separate sections. Bug: 821560, 828367 , 845475 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1769a63aa7d968f31ce3a5854164b81fb80e705b Reviewed-on: https://chromium-review.googlesource.com/1069068 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560584} [modify] https://crrev.com/950668ec9ebb69e439726de235df94cd839fe0ce/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [modify] https://crrev.com/950668ec9ebb69e439726de235df94cd839fe0ce/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
,
May 29 2018
Verified in 69.0.3444.0 Canary, iPhone X iOS 11.4 beta 6, iPhone 6 iOS 10.3.3, iPhone 7 iOS TabGrid popup menu separator is added. |
||||
►
Sign in to add a comment |
||||
Comment 1 by cmasso@google.com
, Apr 5 2018