Issue metadata
Sign in to add a comment
|
Regression: Unwanted bubble top is seen for extension overlay while removing it from chrome |
||||||||||||||||||||||
Issue descriptionChrome Version:66.0.3359.79/10452.42.0 beta channel Daisy,Reks,Kip OS:Chrome OS URL: https://chrome.google.com/webstore/category/extensions?utm_source=chrome-ntp-icon What steps will reproduce the problem? (1)Sign into user >> go to chrome webstore and add any extension (2)Hide in Chrome menu (3)Click to remove it from chrome and observe(Please refer video) Actual: Unwanted bubble top is seen for extension remove overlay Expected: NO such unwanted bubble top should be seen This is a Regression issue as same is working fine in 64.0.3282.190/10176.76.0 Note: 1.Issue is not seen in Linux,Windows OS 2.Issue is also seen in M-65
,
Apr 6 2018
pbos@ did work here recently; Peter, any chance this is related to your changes?
,
Apr 6 2018
pbos@ did work here recently; Peter, any chance this is related to your changes?
,
Apr 6 2018
Maybe. Harmony removes those markers but it's an issue in M66 on ChromeOS as ChromeOS doesn't have Harmony enabled. :( I'm a good owner for it regardless. Thanks!
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f272d1e2923cd3302a6bacf903b40c1b0ed59d9e commit f272d1e2923cd3302a6bacf903b40c1b0ed59d9e Author: Peter Boström <pbos@chromium.org> Date: Mon Apr 09 23:13:08 2018 Hide unanchored extension-uninstall-dialog arrow This dialog arrow is not visible on desktop outside of CrOS as the arrow isn't rendered for Harmony dialogs. Bug: chromium:828365 Change-Id: I61f8776c7c3dd725aba9700efa7412812c2f0811 Reviewed-on: https://chromium-review.googlesource.com/1002540 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#549315} [modify] https://crrev.com/f272d1e2923cd3302a6bacf903b40c1b0ed59d9e/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25dfe9c1d77b4c003bf1282cf83d505aa54f0216 commit 25dfe9c1d77b4c003bf1282cf83d505aa54f0216 Author: Peter Boström <pbos@chromium.org> Date: Tue Apr 10 00:59:44 2018 Remove omnibox separator from rounded omnibar Essentially reverts crrev.com/c/942562 as Material refresh doesn't call for one. This unifies touchable with refresh in this area. Bug: chromium:828365 Change-Id: I2536bd61c5fc6ded1bcf71f720aef558367e012a Reviewed-on: https://chromium-review.googlesource.com/1000422 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#549355} [modify] https://crrev.com/25dfe9c1d77b4c003bf1282cf83d505aa54f0216/chrome/browser/ui/omnibox/omnibox_theme.cc [modify] https://crrev.com/25dfe9c1d77b4c003bf1282cf83d505aa54f0216/chrome/browser/ui/omnibox/omnibox_theme.h [modify] https://crrev.com/25dfe9c1d77b4c003bf1282cf83d505aa54f0216/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/25dfe9c1d77b4c003bf1282cf83d505aa54f0216/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/25dfe9c1d77b4c003bf1282cf83d505aa54f0216/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc [modify] https://crrev.com/25dfe9c1d77b4c003bf1282cf83d505aa54f0216/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.h
,
Apr 10 2018
I don't think this warrants a merge given that we're so close to stable. This is landed in time for M67 so I think we're done. Feel free to request a merge if you disagree.
,
Apr 10 2018
Comment #6 should've gone against issue 826606.
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf81a8fba408c73b0c05b4724b3c07316815b7d9 commit bf81a8fba408c73b0c05b4724b3c07316815b7d9 Author: Peter Boström <pbos@chromium.org> Date: Wed Apr 11 06:17:05 2018 Revert "Remove omnibox separator from rounded omnibar" This reverts commit 25dfe9c1d77b4c003bf1282cf83d505aa54f0216. Reason for revert: Reverted too much. Will follow up with a less-aggressive revert. Original change's description: > Remove omnibox separator from rounded omnibar > > Essentially reverts crrev.com/c/942562 as Material refresh doesn't call > for one. This unifies touchable with refresh in this area. > > Bug: chromium:828365 > Change-Id: I2536bd61c5fc6ded1bcf71f720aef558367e012a > Reviewed-on: https://chromium-review.googlesource.com/1000422 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549355} TBR=pkasting@chromium.org,pbos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:828365 Change-Id: I2001fb86174679cc5dad2d6f58832a3b412de3bf Reviewed-on: https://chromium-review.googlesource.com/1006534 Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#549793} [modify] https://crrev.com/bf81a8fba408c73b0c05b4724b3c07316815b7d9/chrome/browser/ui/omnibox/omnibox_theme.cc [modify] https://crrev.com/bf81a8fba408c73b0c05b4724b3c07316815b7d9/chrome/browser/ui/omnibox/omnibox_theme.h [modify] https://crrev.com/bf81a8fba408c73b0c05b4724b3c07316815b7d9/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/bf81a8fba408c73b0c05b4724b3c07316815b7d9/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/bf81a8fba408c73b0c05b4724b3c07316815b7d9/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc [modify] https://crrev.com/bf81a8fba408c73b0c05b4724b3c07316815b7d9/chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.h |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by karandeepb@chromium.org
, Apr 6 2018