Issue metadata
Sign in to add a comment
|
Regression:Weird horizontal scroll behavior is observed in 'Edit bookmarks' overlay after enabling RTL flag
Reported by
vineetha...@etouch.net,
Apr 3 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3387.0 (Official Build) Revision c8a34cf719bcf005b2e29ca6fba37c6a35505b57-refs/heads/master@{#547597}(64 bit) OS: Mac(10.12.6,10.13.1), 10.13.4(Macbook Pro Touchbar) Pre-condition: Set 'Force UI direction' flag to 'Right-to-left' under chrome://flags What steps will reproduce the problem? (1) Launch Chrome, navigate to NTP or any page, click on bookmark icon to open bookmark bubble. (2) Click on More button to open 'Edit bookmark' overlay. (3) Click on 'New Folder' button and enter long text when entering the folder name. (4) Try to scroll horizontally in the overlay and observe. Actual Result: Weird horizontal scroll behavior is observed. Expected Result: Horizontal scroll behavior should work properly. This is regression issue broken in ‘M-64’ and providing the bisect using per-revision bisect, Good build: 64.0.3260.0(Revision: 514067) Bad build: 64.0.3261.0(Revision: 514329) You are probably looking for a change made after 514116 (known good), but no later than 514117 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/04f1082efb63369e19ace6dde8b62c8702303b88..6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e Suspect:https://chromium.googlesource.com/chromium/src/+/6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e @tapted: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. The issue is not seen Windows(7,8,8.1,10) and Linux(14.04) OS. 2. This issue is also seen on M65 Stable(build #65.0.3325.181), M66 Beta(build #66.0.3359.66) and M67 Dev(build #67.0.3381.1) Thank You!
,
May 4 2018
I've figured out the matrix magic to fix this (visually at least) -- https://chromium-review.googlesource.com/c/chromium/src/+/999076/2/ui/views/controls/scroll_view.cc Still needs a test, and verification that hit-testing still works. And there might be something a little more elegant too. But it's reasonably simple at least.
,
May 7 2018
,
May 7 2018
Huh, neat! Thanks :)
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90ed378494841f712b909f0eff387687c551c343 commit 90ed378494841f712b909f0eff387687c551c343 Author: Trent Apted <tapted@chromium.org> Date: Fri May 11 03:31:50 2018 RTL fixes for views::ScrollView When scrolling with layers, flip the viewport with layer transforms under RTL. This is necessary because the layer-backed scrolling machinery is not privy to the automatic UI flipping done in toolkit-views. ScrollOffsets must be positive, so scrolling horizontally in RTL currently moves the contents to the left. Flipping the viewport layer resolves this and scrolls to the right but reverses the text, so flip the contents to compensate. Testing exposed a quirk of View::ScrollRectToVisible() under RTL on all platforms. It seems only Views::TreeView uses ScrollRectToVisible() to affect horizontal scrolling, but it's currently broken (see http://crbug.com/840236 ). Fix it so we can use it in the test. Bug: 840236 , 828361 Change-Id: Ib16724ff73829a6383be82e7bd11893b3a7e2ffc Reviewed-on: https://chromium-review.googlesource.com/999076 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#557778} [modify] https://crrev.com/90ed378494841f712b909f0eff387687c551c343/ui/views/controls/scroll_view.cc [modify] https://crrev.com/90ed378494841f712b909f0eff387687c551c343/ui/views/controls/scroll_view_unittest.cc [modify] https://crrev.com/90ed378494841f712b909f0eff387687c551c343/ui/views/controls/tree/tree_view.cc [modify] https://crrev.com/90ed378494841f712b909f0eff387687c551c343/ui/views/view.cc
,
May 11 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tapted@chromium.org
, Apr 4 2018Status: Started (was: Assigned)