Nothing happens after clicking on 'Settings' icon on Notification Bubble.
Reported by
aiman.an...@etouch.net,
Apr 3 2018
|
||||||||||
Issue descriptionChrome Version: 67.0.3387.0 (Official Build) Revision c8a34cf719bcf005b2e29ca6fba37c6a35505b57-refs/heads/master@{#547597} (32/64 Bit). OS: Win(7,8,8.1,10), Linux(14.04 LTS). Test-URL: https://chrome.google.com/webstore/detail/editthiscookie/fngmhnnpilhplaeedifhccceomclgfbg/related?utm_source=chrome-ntp-icon Steps to reproduce: 1. Launch Chrome, navigate to above URL and install the extension. 2. After installation, notification bubble appears. 3. Click on 'Settings' gear icon and observe. Actual Result: Nothing happens after clicking on 'Settings' icon. Expected Result: Clicking on 'Settings' icon should be responsive. This is Non-regression issue seen from ‘M-66’ build #66.0.3356.0 (Setting gear icon on notification bubble was introduced from this build.) Note: 1. Issue is also reproducible on Stable #65.0.3325.181 Beta #66.0.3359.66, Dev #67.0.3381.1. 2. Issue is not reproducible on Mac (10.12.6, 10.13.1, 10.13.4) OS. 3. Close button is responsive on the same bubble.
,
Apr 9 2018
Yeah, we should pass SettingsButtonHandler::NONE for non-MD notifications. Uploaded a CL here: https://chromium-review.googlesource.com/#/c/chromium/src/+/1002812
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b9f3458c18c2a7acc4eee8d3cb97ceed85541ce commit 8b9f3458c18c2a7acc4eee8d3cb97ceed85541ce Author: Peter Beverloo <peter@chromium.org> Date: Mon Apr 09 17:11:33 2018 Don't display a settings gear on non-MD extension notifications Inline settings work fine for the MD notifications, but the handler doesn't implement OpenSettings() for non-MD notifications, nor has something sensible to do there. Instead, don't display the button. Bug: 828346 Change-Id: I3a57f940be773e40e4994e4e6e1920f0c83ca3ec Reviewed-on: https://chromium-review.googlesource.com/1002812 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#549207} [modify] https://crrev.com/8b9f3458c18c2a7acc4eee8d3cb97ceed85541ce/chrome/browser/extensions/api/notifications/notifications_api.cc
,
Apr 9 2018
This is a super safe fix that we'd want to consider for M66 since it removes a button that doesn't do anything for most users.
,
Apr 9 2018
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 10 2018
Update : Retested This issue on Windows(7,8,8.1,10) and Linux(14.04 LTS) machines using latest Canary #67.0.3393.0 (64-bit) and issue is fixed. Now, Gear icon is intentionally removed . Kindly review the attached screen-cast. Note: Will soon update the behavior of Windows build #67.0.3393.0 (32-bit) once build will be triggered. Thank you!
,
Apr 10 2018
APPROVING MERGE TO M66. BRANCH:3359
,
Apr 11 2018
Update : Retested this issue on Windows(7,8,8.1,10) machines using latest Dev #67.0.3393.4 (32/64-bit) and issue is fixed. Now, Gear icon is intentionally removed . Kindly review the attached screen-cast. Thank you!
,
Apr 16 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7054e03f2e61e37fd2f8484936ed6b3753e15474 commit 7054e03f2e61e37fd2f8484936ed6b3753e15474 Author: Peter Beverloo <peter@chromium.org> Date: Mon Apr 16 17:38:42 2018 Don't display a settings gear on non-MD extension notifications Inline settings work fine for the MD notifications, but the handler doesn't implement OpenSettings() for non-MD notifications, nor has something sensible to do there. Instead, don't display the button. Bug: 828346 Change-Id: I3a57f940be773e40e4994e4e6e1920f0c83ca3ec Reviewed-on: https://chromium-review.googlesource.com/1002812 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#549207}(cherry picked from commit 8b9f3458c18c2a7acc4eee8d3cb97ceed85541ce) Reviewed-on: https://chromium-review.googlesource.com/1014261 Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#719} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/7054e03f2e61e37fd2f8484936ed6b3753e15474/chrome/browser/extensions/api/notifications/notifications_api.cc
,
Apr 17 2018
Update : Retested this issue on Windows(7,8,8.1,10) machines using latest Stable #66.0.3359.117 (32/64-bit) and issue is fixed. Now, Gear icon is intentionally removed . Kindly review the attached screen-cast. Thank you!
,
Apr 17 2018
Thank you for the confirmation! |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by rbasuvula@chromium.org
, Apr 3 2018