Regression:Unwanted selection of Password is seen on pressing tab multiple times.
Reported by
shruti.j...@etouch.net,
Apr 3 2018
|
|||
Issue descriptionChrome version: 67.0.3387.0 Revision c8a34cf719bcf005b2e29ca6fba37c6a35505b57-refs/heads/master@{#547597}(32/64 bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.4) Pre-condition:Login with valid credentials in gmail.com Steps to reproduce: 1.Launch chrome and navigate to chrome://settings/passwords. 2.Click on three dots 'More actions' and select 'Details' password overlay opens. 3.Press Tab until focus reaches ‘Done’ button. 4.Hit Tab Key once more and observe. Actual Result:Unwanted selection of Password is seen on pressing tab multiple times. Expected Result:Password should not be selected, on pressing tab multiple times. This is a regression issue broken in “M-65”and providing with the per-revision bisect info: Good Build:65.0.3318.0(Revision:528542) Bad Build:65.0.3319.0(Revision:528844) You are probably looking for a change made after 528748 (known good),but no later than 528749 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perfbuilds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/0a7ce7463ceae66f14cbacabd236fea7f56b5bf1..e17fd7199e57c383c2a1fdbf4b26826fb0de546b Suspect:https://chromium.googlesource.com/chromium/src/+/e17fd7199e57c383c2a1fdbf4b26826fb0de546b @Scott Chen:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note:After step 4 Focus shifts on ‘Chrome chip’ in omni-box, but unnecessarily password text selection is seen. Thank You!
,
Jun 11 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03a72bc8b12df30e843e757c23866c0339eb6085 commit 03a72bc8b12df30e843e757c23866c0339eb6085 Author: Scott Chen <scottchen@chromium.org> Date: Wed Jun 13 01:29:29 2018 Settings: unselect password input text when unfocused Bug: 828333 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If101939b46697c7da6e9c0a0fc4f7219c83f11c1 Reviewed-on: https://chromium-review.googlesource.com/1095641 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#566676} [modify] https://crrev.com/03a72bc8b12df30e843e757c23866c0339eb6085/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html [modify] https://crrev.com/03a72bc8b12df30e843e757c23866c0339eb6085/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js
,
Jun 20 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by scottchen@chromium.org
, May 14 2018