New issue
Advanced search Search tips

Issue 828331 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Task

Blocked on:
issue 822131
issue 829251
issue 830291
issue 830292

Blocking:
issue 846235



Sign in to add a comment

Add virtual test for ServiceWorkerServicification aka NetS13nServiceWorker

Project Member Reported by shimazu@google.com, Apr 3 2018

Issue description

ServiceWorkerServicification feature flag goes to the unique path.
It needs to be tested separately.
 

Comment 1 by shimazu@google.com, Apr 3 2018

Blockedon: 822131
This is blocked on 822131 because many virtual tests hit NOTREACHED in ProceedWithResponse.
Blockedon: 829251

Comment 3 by falken@chromium.org, Apr 10 2018

Blocking: 715640
Blockedon: 830291
Blockedon: 830292
Created a CL: crrev.com/c/1025593
Once most of them passes (= issues blocking this are resolved), let's update the expectations and land it.

Comment 7 by dxie@chromium.org, May 15 2018

Labels: -Pri-2 Proj-Servicification-Canary Pri-1
Owner: shimazu@chromium.org
Status: Started (was: Available)

Comment 8 by falken@chromium.org, May 24 2018

Blocking: -715640 846235
Project Member

Comment 9 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8cb9f203b9bbbd853478eaf5621ca1afe26c84d

commit c8cb9f203b9bbbd853478eaf5621ca1afe26c84d
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Fri May 25 05:24:57 2018

NetS13nServiceWorker: Add virtual tests for ServiceWorkerServicification

Bug:  828331 
Change-Id: I6198fe5be6de71a33fc3bc191d16802c92b2751f
Reviewed-on: https://chromium-review.googlesource.com/1025593
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561774}
[modify] https://crrev.com/c8cb9f203b9bbbd853478eaf5621ca1afe26c84d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c8cb9f203b9bbbd853478eaf5621ca1afe26c84d/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/c8cb9f203b9bbbd853478eaf5621ca1afe26c84d/third_party/WebKit/LayoutTests/virtual/service-worker-servicification/external/wpt/service-workers/service-worker/README.txt
[add] https://crrev.com/c8cb9f203b9bbbd853478eaf5621ca1afe26c84d/third_party/WebKit/LayoutTests/virtual/service-worker-servicification/external/wpt/service-workers/service-worker/appcache-ordering-main.https-expected.txt
[add] https://crrev.com/c8cb9f203b9bbbd853478eaf5621ca1afe26c84d/third_party/WebKit/LayoutTests/virtual/service-worker-servicification/external/wpt/service-workers/service-worker/navigation-timing.https-expected.txt
[add] https://crrev.com/c8cb9f203b9bbbd853478eaf5621ca1afe26c84d/third_party/WebKit/LayoutTests/virtual/service-worker-servicification/http/tests/serviceworker/README.txt

Status: Fixed (was: Started)

Sign in to add a comment