New issue
Advanced search Search tips

Issue 828326 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q2



Sign in to add a comment

Popup Menu: add preparation for presentation

Project Member Reported by gambard@chromium.org, Apr 3 2018

Issue description

Before the presentation of the popup menus, the browser should have a preparation phase where the omnibox is unfocused.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b751854bd8d0e436a7d1f2b5f6540e1608484949

commit b751854bd8d0e436a7d1f2b5f6540e1608484949
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Apr 05 09:42:09 2018

Add preparation for the popup menus

This CL adds the preparation steps before presenting the popup menus.
In those preparation steps, the browser is dismissing all the other
menus the user can be interacting with.

Bug:  828326 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib4b34686790fa8c8acf2bdbf5abb099e916366bd
Reviewed-on: https://chromium-review.googlesource.com/991992
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548376}
[modify] https://crrev.com/b751854bd8d0e436a7d1f2b5f6540e1608484949/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/b751854bd8d0e436a7d1f2b5f6540e1608484949/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/b751854bd8d0e436a7d1f2b5f6540e1608484949/ios/chrome/browser/ui/commands/popup_menu_commands.h
[modify] https://crrev.com/b751854bd8d0e436a7d1f2b5f6540e1608484949/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/b751854bd8d0e436a7d1f2b5f6540e1608484949/ios/chrome/browser/ui/tools_menu/public/tools_menu_configuration_provider.h
[modify] https://crrev.com/b751854bd8d0e436a7d1f2b5f6540e1608484949/tools/metrics/actions/actions.xml

Status: Fixed (was: Assigned)

Comment 3 by cmasso@google.com, Apr 10 2018

Labels: -Pri-3 Pri-2

Sign in to add a comment