New issue
Advanced search Search tips

Issue 828312 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 791377



Sign in to add a comment

Change accessibility labels for More Actions buttons in chrome:settings/passwords

Project Member Reported by cfroussios@chromium.org, Apr 3 2018

Issue description

The accessibility labels for the More Actions buttons in chrome:settings/passwords should be:

"Saved passwords, more actions, button" for the table
"More actions, password for XXX on YYY" for every row
"More actions, saved account for XXX on YYY" for federated accounts

Requested in bug 791377
 
Blocking: 791377
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caa4f985b12d321d4ac3e4b38a8e4f5a3abc2155

commit caa4f985b12d321d4ac3e4b38a8e4f5a3abc2155
Author: Christos Froussios <cfroussios@chromium.org>
Date: Fri Apr 06 15:05:54 2018

[Password Manager] More Actions aria labels for chrome:settings/passwords

The aria labels for the 'More Actions' buttons will now also give context,
mentioning whether the apply to all passwords or the specific user and
domain.

Bug:  828312 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If94daaa5b6a903b3e0887caea13a2446eef52bfd
Reviewed-on: https://chromium-review.googlesource.com/964330
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548777}
[modify] https://crrev.com/caa4f985b12d321d4ac3e4b38a8e4f5a3abc2155/chrome/app/settings_strings.grdp
[modify] https://crrev.com/caa4f985b12d321d4ac3e4b38a8e4f5a3abc2155/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[modify] https://crrev.com/caa4f985b12d321d4ac3e4b38a8e4f5a3abc2155/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html
[modify] https://crrev.com/caa4f985b12d321d4ac3e4b38a8e4f5a3abc2155/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.js
[modify] https://crrev.com/caa4f985b12d321d4ac3e4b38a8e4f5a3abc2155/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/caa4f985b12d321d4ac3e4b38a8e4f5a3abc2155/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Status: Fixed (was: Assigned)

Sign in to add a comment