Issue metadata
Sign in to add a comment
|
Regression: Page doesnot get emulated into device mode after undocking dev tools into seperate window.
Reported by
db...@etouch.net,
Apr 3 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3387.0 Revision c8a34cf719bcf005b2e29ca6fba37c6a35505b57-refs/heads/master@{#547597}(32/64 bit) OS: Windows(7,8,8.1,10), Linux(14.04 LTS) What steps will reproduce the problem? (1) Launch chrome, open NTP and open dev tools window on it. (2) Click on 'Customize and Control Dev-tool' icon and then click on 'Undock into seperate window' option. (3) Now click on Toggle device toolbar icon and observe. Actul: Page doesnot get emulated into device mode after undocking dev tools into seperate window. Expected: Page should get emulated into device mode after undocking dev tools into seperate window This is a regression issue, broken in 'M67', proving bisect using bisect per revision. Good Build:67.0.3381.0 Bad Build:67.0.3382.0 You are probably looking for a change made after 546285 (known good), but no later than 546286 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/99346eaf452e11400555b3901e892c76f5534372..e616115a9b1dca27ffdf447c79b4413305c49bb4 Suspect: https://chromium.googlesource.com/chromium/src/+/e616115a9b1dca27ffdf447c79b4413305c49bb4 @fdoray: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue is not seen on Mac(10.12.6,10.13.1,10.13.4) Os. Thank you.
,
Apr 4 2018
Fix uploaded for review at https://chromium-review.googlesource.com/c/chromium/src/+/996478
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43eb8e11ef747705a3b180545a5677d37a2e022d commit 43eb8e11ef747705a3b180545a5677d37a2e022d Author: Francois Doray <fdoray@chromium.org> Date: Mon Apr 09 15:12:12 2018 Force rendering of DevTools' toolbox WebContents. The DevTools toolbox holds a placeholder for the inspected WebContents. When the placeholder is resized, a frame is requested. The inspected WebContents is resized when the frame is rendered. This CL forces rendering of the toolbox at all times (even when occluded), to make sure that a frame can be rendered even when the inspected WebContents fully covers the toolbox. Bug: 828307 Change-Id: Id966ec985b97b3a0978f73f38929dc2b51cbd1c3 Reviewed-on: https://chromium-review.googlesource.com/996478 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#549176} [modify] https://crrev.com/43eb8e11ef747705a3b180545a5677d37a2e022d/chrome/browser/devtools/devtools_window.cc
,
Apr 9 2018
Should be fixed. Is it possible to confirm that the fix works on all platforms?
,
Apr 10 2018
Update : Retested This issue on Windows(7,8,8.1,10) and Linux(14.04 LTS) machines using latest Canary #67.0.3393.0 (64-bit) and issue is fixed. Kindly review the attached screen-cast. Note: Will soon update the behavior of Windows build #67.0.3393.0 (32-bit) once build will be triggered. Thank you!
,
Apr 11 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Apr 3 2018