Remove --enable-mac-views-app-list (it won't ship) - App Info Dialog [on Mac] |
||
Issue descriptionChrome Version : 67 See discussion at https://bugs.chromium.org/p/chromium/issues/detail?id=602525#c21 mostly This isue is to remove the flag and stop linking in the code on mac. Maybe we want to extend this to all desktop platforms (i.e. non-ChromeOS). Maybe with a plan to map the context menu on chrome://apps to something else too -- I think that's still hooked up (except on Mac). The access point from chrome://extensions is already gone.
,
Apr 5 2018
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1ba9bd1813425334f84abf5e827063f80478bf4 commit f1ba9bd1813425334f84abf5e827063f80478bf4 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Apr 06 12:32:49 2018 macviews: remove app info dialog flag and a bit of wiring This entire dialog will be replaced soon, but for now, remove the flag on Mac and the wiring that hooks up the flag. It's not currently possible to remove the dialog code wholesale because the NTP code for examining an app always uses ShowAppInfoInNativeDialog(). Bug: 828270 Change-Id: Ieae022a5a8733819eadbb41e95c9ce67f5e9e73a Reviewed-on: https://chromium-review.googlesource.com/998013 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#548749} [modify] https://crrev.com/f1ba9bd1813425334f84abf5e827063f80478bf4/chrome/browser/about_flags.cc [modify] https://crrev.com/f1ba9bd1813425334f84abf5e827063f80478bf4/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/f1ba9bd1813425334f84abf5e827063f80478bf4/chrome/browser/flag_descriptions.h [modify] https://crrev.com/f1ba9bd1813425334f84abf5e827063f80478bf4/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
,
Apr 6 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by ellyjo...@chromium.org
, Apr 3 2018Owner: ellyjo...@chromium.org
Status: Assigned (was: Available)