Thanks for this report, mgiuca. I created the reddit post a few days ago as I noticed this new behavior. IIRC the URL bar wasn't shown before v66. With v66 I'm able to reproduce this every time (am on beta). I'll wait for v67 and create a new "app shortcut" then.

#1 So did you create this app by manually adding it using Menu -> More tools -> Add to shelf? Then chose "Open in window"? That seems to be the only way to get this app installed and running in a window.

We reproduced using Menu -> More tools -> Add to shelf (manually added Secure Shell as a Bookmark app). This looks like it was caused by r537588 which now shows the location bar for insecure (non-https) connections. It looks like the "chrome-extension://" scheme is being considered insecure because it is not "https". It should be considered a secure context.

I'll take this back and fix it. We can probably merge this into 66 so the bug won't go out to stable channel.

Thanks for the report.

WIP CL: https://crrev.com/c/991932

Correct, I created it manually. Also I don't see any difference between bookmarking the secure shell app and opening it via ctrl + alt + t. Both ways open the secure shell and then I added it to the shelf using Menu -> More tools -> Add to shelf.

Thanks for working on it!

If you use Ctrl+Alt+T, it will always open in a new tab, right? (Even if you've installed the app and set it to open as window, Ctrl+Alt+T just opens the tab.)

Technically when you use Add to shelf, you're creating a new app that links to the web page provided by the Secure Shell extension (just as you would create an app that links to a normal web page). So it's quite different from just opening the page directly. I didn't even know this was possible to create such an app until yesterday (which is why we didn't test this case). Sorry for the inconvenience.

Thanks for clarifying. Then both of us learned something new I guess :-)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/422968098ba7d946bd528ecc633cfe0e33cf1227

commit 422968098ba7d946bd528ecc633cfe0e33cf1227
Author: Matt Giuca <mgiuca@chromium.org>
Date: Thu Apr 05 09:33:06 2018

Bookmark apps created from extension pages no longer show location bar.

Fixed a regression introduced by r537588 which showed a location bar on
all non-https pages. Extension pages are secure, but have scheme
chrome-extension, so did not pass this test. Now chrome-extension pages
are special-cased to be allowed without a location bar.

Bug:  828233 
Change-Id: Ic792007ddb8d8d29ab0dc0b82500e4833f6f2c7c
Reviewed-on: https://chromium-review.googlesource.com/991932
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548372}
[modify] https://crrev.com/422968098ba7d946bd528ecc633cfe0e33cf1227/chrome/browser/ui/extensions/hosted_app_browser_controller.cc
[modify] https://crrev.com/422968098ba7d946bd528ecc633cfe0e33cf1227/chrome/browser/ui/extensions/hosted_app_browsertest.cc

Requesting merge to 66. Rationale: Regression in 66.

This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Full steps to reproduce (since I didn't provide them in original report):

1. Ctrl+Alt+T to open a new secure shell.
2. Chrome menu -> More tools -> Add to shelf.
3. OK.
4. Right-click Secure Shell icon on shelf -> Open in window.
5. Left-click Secure Shell icon on shelf.

Expected result:
Window has no location bar shown.

Actual result:
Window has a location bar, as shown in screenshot attached to original post.

We should verify this works on canary first before merging back to 66.

I will as soon as possible. I think CrOS canary is usually a few days late, isn't it? So this could delay the merge by a fair bit.

The bug reproduces on all platforms so we can try mac or windows canary.

#13 ah OK

Just verified on macOS Canary 67.0.3390.0 and the location bar is no longer there.

Also verified on Windows Canary 67.0.3390.0.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92e3aac153c392b262dc0ccb06a470b1224e062d

commit 92e3aac153c392b262dc0ccb06a470b1224e062d
Author: Matt Giuca <mgiuca@chromium.org>
Date: Tue Apr 10 00:07:31 2018

Bookmark apps created from extension pages no longer show location bar.

Fixed a regression introduced by r537588 which showed a location bar on
all non-https pages. Extension pages are secure, but have scheme
chrome-extension, so did not pass this test. Now chrome-extension pages
are special-cased to be allowed without a location bar.

Bug:  828233 
Change-Id: Ic792007ddb8d8d29ab0dc0b82500e4833f6f2c7c
Reviewed-on: https://chromium-review.googlesource.com/991932
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#548372}(cherry picked from commit 422968098ba7d946bd528ecc633cfe0e33cf1227)
Reviewed-on: https://chromium-review.googlesource.com/1003712
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#637}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/92e3aac153c392b262dc0ccb06a470b1224e062d/chrome/browser/ui/extensions/hosted_app_browser_controller.cc
[modify] https://crrev.com/92e3aac153c392b262dc0ccb06a470b1224e062d/chrome/browser/ui/extensions/hosted_app_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0557a7561f8f4dd710499f692629099b59ae1fe4

commit 0557a7561f8f4dd710499f692629099b59ae1fe4
Author: Matt Giuca <mgiuca@chromium.org>
Date: Wed Apr 11 00:21:52 2018

Revert "Bookmark apps created from extension pages no longer show location bar."

This reverts commit 92e3aac153c392b262dc0ccb06a470b1224e062d.

Reason for revert: Broke compile due to changes in branch.

Original change's description:
> Bookmark apps created from extension pages no longer show location bar.
> 
> Fixed a regression introduced by r537588 which showed a location bar on
> all non-https pages. Extension pages are secure, but have scheme
> chrome-extension, so did not pass this test. Now chrome-extension pages
> are special-cased to be allowed without a location bar.
> 
> Bug:  828233 
> Change-Id: Ic792007ddb8d8d29ab0dc0b82500e4833f6f2c7c
> Reviewed-on: https://chromium-review.googlesource.com/991932
> Commit-Queue: Matt Giuca <mgiuca@chromium.org>
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#548372}(cherry picked from commit 422968098ba7d946bd528ecc633cfe0e33cf1227)
> Reviewed-on: https://chromium-review.googlesource.com/1003712
> Reviewed-by: Matt Giuca <mgiuca@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3359@{#637}
> Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}

TBR=mgiuca@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  828233 
Change-Id: Id4e1e51868404a00481ebc1927484ed26658a802
Reviewed-on: https://chromium-review.googlesource.com/1006334
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#667}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/0557a7561f8f4dd710499f692629099b59ae1fe4/chrome/browser/ui/extensions/hosted_app_browser_controller.cc
[modify] https://crrev.com/0557a7561f8f4dd710499f692629099b59ae1fe4/chrome/browser/ui/extensions/hosted_app_browsertest.cc

Had to revert the merge. Will try again.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75113572d7d3557becd88bbc77b21299b242fc80

commit 75113572d7d3557becd88bbc77b21299b242fc80
Author: Matt Giuca <mgiuca@chromium.org>
Date: Wed Apr 11 06:06:06 2018

Reland "Bookmark apps created from extension pages no longer show location bar."

This is a reland of 92e3aac153c392b262dc0ccb06a470b1224e062d. Code
hand-modified to compile properly against the 3359 branch. Manually
verified that it compiles on Linux, and the fix works as intended, and
the test passes.

Original change's description:
> Bookmark apps created from extension pages no longer show location bar.
>
> Fixed a regression introduced by r537588 which showed a location bar on
> all non-https pages. Extension pages are secure, but have scheme
> chrome-extension, so did not pass this test. Now chrome-extension pages
> are special-cased to be allowed without a location bar.
>
> Bug:  828233 
> Change-Id: Ic792007ddb8d8d29ab0dc0b82500e4833f6f2c7c
> Reviewed-on: https://chromium-review.googlesource.com/991932
> Commit-Queue: Matt Giuca <mgiuca@chromium.org>
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#548372}(cherry picked from commit 422968098ba7d946bd528ecc633cfe0e33cf1227)
> Reviewed-on: https://chromium-review.googlesource.com/1003712
> Reviewed-by: Matt Giuca <mgiuca@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3359@{#637}
> Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}

Bug:  828233 
Change-Id: Ie22648e79c0f32515559e3adc01077ae1eb40a5a
Reviewed-on: https://chromium-review.googlesource.com/1005375
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#674}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/75113572d7d3557becd88bbc77b21299b242fc80/chrome/browser/ui/extensions/hosted_app_browser_controller.cc
[modify] https://crrev.com/75113572d7d3557becd88bbc77b21299b242fc80/chrome/browser/ui/extensions/hosted_app_browsertest.cc