[CRD iOS] Connection failure after session connected should be logged as CONNECTION_DROPPED, not CONNECTION_FAILED |
||||||
Issue descriptionAs described on the title. Logging it as CONNECTION_FAILED messes up the stats.
,
Apr 13 2018
This only affects Chromoting but not the Chrome browser.
,
Apr 14 2018
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be48573e001e69a491bb0f6ab71d85888b9000bc commit be48573e001e69a491bb0f6ab71d85888b9000bc Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Apr 16 19:49:49 2018 [CRD iOS] Report connection failure after CONNECTED as CONNECTION_DROPPED Previously we report connection failure both before and after CONNECTED as CONNECTION_FAILED, which makes it harder to calculate durability. This CL makes sure connection failures after CONNECTED are reported as CONNECTION_DROPPED. Bug: 828210 Change-Id: I8689718a5741aec6b1ea49172838b44857ca4108 Reviewed-on: https://chromium-review.googlesource.com/1011354 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550440}(cherry picked from commit 53e4f3ef22d11c09ba36cae9add7c028b1472220) Reviewed-on: https://chromium-review.googlesource.com/1012789 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#23} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/be48573e001e69a491bb0f6ab71d85888b9000bc/remoting/client/chromoting_session.cc [modify] https://crrev.com/be48573e001e69a491bb0f6ab71d85888b9000bc/remoting/client/client_telemetry_logger.cc [modify] https://crrev.com/be48573e001e69a491bb0f6ab71d85888b9000bc/remoting/client/client_telemetry_logger.h
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53e4f3ef22d11c09ba36cae9add7c028b1472220 commit 53e4f3ef22d11c09ba36cae9add7c028b1472220 Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Apr 13 00:42:15 2018 [CRD iOS] Report connection failure after CONNECTED as CONNECTION_DROPPED Previously we report connection failure both before and after CONNECTED as CONNECTION_FAILED, which makes it harder to calculate durability. This CL makes sure connection failures after CONNECTED are reported as CONNECTION_DROPPED. Bug: 828210 Change-Id: I8689718a5741aec6b1ea49172838b44857ca4108 Reviewed-on: https://chromium-review.googlesource.com/1011354 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#550440} [modify] https://crrev.com/53e4f3ef22d11c09ba36cae9add7c028b1472220/remoting/client/chromoting_session.cc [modify] https://crrev.com/53e4f3ef22d11c09ba36cae9add7c028b1472220/remoting/client/client_telemetry_logger.cc [modify] https://crrev.com/53e4f3ef22d11c09ba36cae9add7c028b1472220/remoting/client/client_telemetry_logger.h |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Apr 13 2018