New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 828207 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 829190


Show other hotlists

Hotlists containing this issue:
Hotlist-2


Sign in to add a comment

After changing the display settings, launcher all apps view doesn't cover the entire external display

Project Member Reported by mkarkada@chromium.org, Apr 2 2018

Issue description

Chrome OS Version: 10452.30.0, 66.0.3359.67 beta channel kevin, elm

What steps will reproduce the problem?
(1) Connect external monitor to the device (say HP LP2465)
(2) On the external display, open launcher and view all apps screen
(3) Goto chrome://settings/display page and change the display arrangement. My arrangement was as shown in attached screenshot.
(4) Again on the external display, open launcher and view all apps screen

What happens instead?
Launcher all apps screen is displaced. Certain regions of external display are not covered by the launcher view. This happens post changing the display settings to any arrangement.

Expected behavior?
Launcher all apps view must cover the entire external display region.

Please refer the attached issue video.
 
Display arrangement.png
160 KB View Download
Labels: -Restrict-View-Google
Owner: warx@chromium.org
Status: Assigned (was: Untriaged)
warx@ please triage
Cc: newcomer@chromium.org
Labels: Touch-Friendly-Launcher-Urgent
Owner: weidongg@chromium.org
weidongg@, please take a look. If it's not a complex fix we should consider merging it. Stable cut is the 12th!
Blockedon: 829190
Sure, the blocking  bug 829190  is fixed in ToT, I will work on it.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e843f40a378754230e7e2dffae361575c81e84b

commit 6e843f40a378754230e7e2dffae361575c81e84b
Author: Weidong Guo <weidongg@chromium.org>
Date: Thu Apr 05 21:50:02 2018

Fix fullscreen app list bounds issue

Changes:
Use the relative y of work area to display bounds to set fullscreen app
list bounds. This fixes the app list bounds in non-primary displays.

BUG= 828207 

Change-Id: I2bf2ebc49c617240ef9df869020c95996ef18e3f
Reviewed-on: https://chromium-review.googlesource.com/998517
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548568}
[modify] https://crrev.com/6e843f40a378754230e7e2dffae361575c81e84b/ui/app_list/views/app_list_view.cc

Status: Fixed (was: Assigned)
Cc: ryutas@chromium.org jayhlee@chromium.org weidongg@chromium.org
 Issue 835700  has been merged into this issue.
Labels: Merge-Request-66
Status: Started (was: Fixed)
Changing status so hopefully this gets seen.
Have you confirmed changes in ToT/M67?
Labels: M-67
Yes, I confirm the change is in M67. (67.0.3390.0)
Labels: -Merge-Request-66 Merge-Approved-66
Project Member

Comment 15 by bugdroid1@chromium.org, May 2 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d732b8ef3697af2d08d8bcecb8f6b67826030c18

commit d732b8ef3697af2d08d8bcecb8f6b67826030c18
Author: Weidong Guo <weidongg@chromium.org>
Date: Wed May 02 17:14:43 2018

Fix fullscreen app list bounds issue

Changes:
Use the relative y of work area to display bounds to set fullscreen app
list bounds. This fixes the app list bounds in non-primary displays.

BUG= 828207 
TBR=khmel@chromium.org

Change-Id: I2bf2ebc49c617240ef9df869020c95996ef18e3f
Reviewed-on: https://chromium-review.googlesource.com/998517
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#548568}(cherry picked from commit 6e843f40a378754230e7e2dffae361575c81e84b)
Reviewed-on: https://chromium-review.googlesource.com/1040165
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#786}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/d732b8ef3697af2d08d8bcecb8f6b67826030c18/ui/app_list/views/app_list_view.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on M67 (10575.58.0, 67.0.3396.99) elm.

Sign in to add a comment