[CRD iOS] Crash at remoting::DesktopViewport::SetSurfaceSize(int, int) |
||
Issue description2 occurrences as of Apr 2. Could be something like connection died when the keyboard is being shown/hidden.
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2967489d082e4175e49956f5dd5b6d50468c5f73 commit 2967489d082e4175e49956f5dd5b6d50468c5f73 Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Apr 06 23:35:59 2018 [CRD iOS] Fix crash on SetSurfaceSize(int, int) We got quite a few crash reports on DesktopViewport::SetSurfaceSize(int, int). My suspicion is that the connection is dropped when the keyboard is being shown/hidden so animateSurfaceSize: is called when gestureInterpreter is already a nullptr, causing a segfault. This is very hard to repro though since the connection must be dropped (by killing the host?) during the animation and the animation must tick one frame before the view closes itself. This CL fixes this by making both interpreters have the same lifetime as RemotingClient and use SetContext() to enable/disable them. Bug: 828204 Change-Id: I41c14ae8bc1d6edce8f3c32eb958256809821425 Reviewed-on: https://chromium-review.googlesource.com/1000096 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#548969} [modify] https://crrev.com/2967489d082e4175e49956f5dd5b6d50468c5f73/remoting/client/gesture_interpreter.cc [modify] https://crrev.com/2967489d082e4175e49956f5dd5b6d50468c5f73/remoting/client/gesture_interpreter.h [modify] https://crrev.com/2967489d082e4175e49956f5dd5b6d50468c5f73/remoting/client/input/keyboard_interpreter.cc [modify] https://crrev.com/2967489d082e4175e49956f5dd5b6d50468c5f73/remoting/client/input/keyboard_interpreter.h [modify] https://crrev.com/2967489d082e4175e49956f5dd5b6d50468c5f73/remoting/client/ui/desktop_viewport.cc [modify] https://crrev.com/2967489d082e4175e49956f5dd5b6d50468c5f73/remoting/ios/app/host_view_controller.mm [modify] https://crrev.com/2967489d082e4175e49956f5dd5b6d50468c5f73/remoting/ios/session/remoting_client.h [modify] https://crrev.com/2967489d082e4175e49956f5dd5b6d50468c5f73/remoting/ios/session/remoting_client.mm
,
Apr 10 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by yuweih@chromium.org
, Apr 5 2018