New issue
Advanced search Search tips

Issue 828190 link

Starred by 2 users

Issue metadata

Status: ExternalDependency
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-XR



Sign in to add a comment

Support VR head movement in tests

Project Member Reported by bsheedy@chromium.org, Apr 2 2018

Issue description

Now that Issue 782845 is fixed, the VrCore fake head tracker works properly in Chromium tests. Thus, we should make it possible for tests to have simulated head movement, or lock the head position into a constant pose to improve consistency.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/1fcfd9b6d53d5e277666487bc2acb59faf237346

commit 1fcfd9b6d53d5e277666487bc2acb59faf237346
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Apr 03 18:23:16 2018

Add start service functionality on Android

Adds the ability for Devil/Telemetry to start services on Android,
equivalent to adb shell am start-service. This is currently only needed by
VR tests to start the fake VrCore head tracking service, but could be
useful for other Android benchmarks.

Bug: chromium:828190
Change-Id: Ibeb300aab41bce8316b495d39f49880b46a6834b
Reviewed-on: https://chromium-review.googlesource.com/991118
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/1fcfd9b6d53d5e277666487bc2acb59faf237346/devil/devil/android/device_utils.py
[modify] https://crrev.com/1fcfd9b6d53d5e277666487bc2acb59faf237346/telemetry/telemetry/core/android_platform.py
[modify] https://crrev.com/1fcfd9b6d53d5e277666487bc2acb59faf237346/devil/devil/android/device_utils_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/996e8691caeb6b7aeb0a00f76212af44cef5b30d

commit 996e8691caeb6b7aeb0a00f76212af44cef5b30d
Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Apr 03 20:31:25 2018

Roll src/third_party/catapult/ 29a751cec..1fcfd9b6d (2 commits)

https://chromium.googlesource.com/catapult.git/+log/29a751ceced1..1fcfd9b6d53d

$ git log 29a751cec..1fcfd9b6d --date=short --no-merges --format='%ad %ae %s'
2018-04-03 bsheedy Add start service functionality on Android
2018-04-03 simonhatch Dashboard - Add default filters back to skip_files.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:828190,chromium:828405


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I9315a557b61fd7e3028cd623a9839640bddd7215
Reviewed-on: https://chromium-review.googlesource.com/992863
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547811}
[modify] https://crrev.com/996e8691caeb6b7aeb0a00f76212af44cef5b30d/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd2dbf7b88b6df2983951b876a31df27d7fa8830

commit cd2dbf7b88b6df2983951b876a31df27d7fa8830
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Apr 04 02:10:31 2018

Add VrCore head tracking support to VR benchmarks

Adds support for and enables the fake VrCore head tracker in VR
benchmarks. This causes the tests to ignore any actual movement from
the test device, and instead sweep the view back and forth horizontally
in 180 degree arcs.

Bug: 828190
Change-Id: I25681867116360d5071a01fcea725994fe340e74
Reviewed-on: https://chromium-review.googlesource.com/993872
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547954}
[modify] https://crrev.com/cd2dbf7b88b6df2983951b876a31df27d7fa8830/chrome/android/shared_preference_files/test/vr_cardboard_skipdon_setupcomplete.json
[modify] https://crrev.com/cd2dbf7b88b6df2983951b876a31df27d7fa8830/chrome/android/shared_preference_files/test/vr_ddview_skipdon_setupcomplete.json
[modify] https://crrev.com/cd2dbf7b88b6df2983951b876a31df27d7fa8830/tools/perf/contrib/vr_benchmarks/BUILD.gn
[modify] https://crrev.com/cd2dbf7b88b6df2983951b876a31df27d7fa8830/tools/perf/contrib/vr_benchmarks/shared_android_vr_page_state.py
[modify] https://crrev.com/cd2dbf7b88b6df2983951b876a31df27d7fa8830/tools/perf/contrib/vr_benchmarks/vr_browsing_mode_pages.py
[add] https://crrev.com/cd2dbf7b88b6df2983951b876a31df27d7fa8830/tools/perf/contrib/vr_benchmarks/vr_story_set.py
[modify] https://crrev.com/cd2dbf7b88b6df2983951b876a31df27d7fa8830/tools/perf/contrib/vr_benchmarks/webvr_sample_pages.py
[modify] https://crrev.com/cd2dbf7b88b6df2983951b876a31df27d7fa8830/tools/perf/contrib/vr_benchmarks/webvr_wpr_pages.py

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/15419574e47bdd9e979f46dd726747ae5eb5f51d

commit 15419574e47bdd9e979f46dd726747ae5eb5f51d
Author: bsheedy <bsheedy@chromium.org>
Date: Thu Apr 05 19:51:02 2018

Fix service starting on N and below

Starting services on N and below is done via "am startservice", while
on O and above, it's done via "am start-service". When service starting
was initially added, it was only tested on O, so the current
implementation was failing on N and below due to am not knowing what
"start-service" was.

Bug: chromium:828190
Change-Id: I3444563d66beb8ec0accbe45878be98035e43a4f
Reviewed-on: https://chromium-review.googlesource.com/998516
Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>

[modify] https://crrev.com/15419574e47bdd9e979f46dd726747ae5eb5f51d/devil/devil/android/device_utils.py
[modify] https://crrev.com/15419574e47bdd9e979f46dd726747ae5eb5f51d/devil/devil/android/device_utils_test.py

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58f68d3c780361b37be03cfeae384d4f9568c226

commit 58f68d3c780361b37be03cfeae384d4f9568c226
Author: bsheedy <bsheedy@chromium.org>
Date: Thu Apr 05 20:16:39 2018

Add VrCore head tracking support to instrumentation tests

Adds support for using the VrCore head tracking service in VR
instrumentation tests. This can be used either via an annotation, which
results in slightly faster test execution, or directly in a test via a
utility class.

Bug: 828190
Change-Id: Id4f806939b7242c084ac467bed2214b7b0c73911
Reviewed-on: https://chromium-review.googlesource.com/996901
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548537}
[modify] https://crrev.com/58f68d3c780361b37be03cfeae384d4f9568c226/chrome/android/BUILD.gn
[modify] https://crrev.com/58f68d3c780361b37be03cfeae384d4f9568c226/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellDialogTest.java
[modify] https://crrev.com/58f68d3c780361b37be03cfeae384d4f9568c226/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/rules/ChromeTabbedActivityVrTestRule.java
[modify] https://crrev.com/58f68d3c780361b37be03cfeae384d4f9568c226/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/rules/CustomTabActivityVrTestRule.java
[add] https://crrev.com/58f68d3c780361b37be03cfeae384d4f9568c226/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/rules/HeadTrackingMode.java
[modify] https://crrev.com/58f68d3c780361b37be03cfeae384d4f9568c226/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/rules/VrTestRule.java
[modify] https://crrev.com/58f68d3c780361b37be03cfeae384d4f9568c226/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/rules/WebappActivityVrTestRule.java
[add] https://crrev.com/58f68d3c780361b37be03cfeae384d4f9568c226/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/HeadTrackingUtils.java

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23601295d37f6118c209684d27edbfff3c1da332

commit 23601295d37f6118c209684d27edbfff3c1da332
Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Apr 05 23:01:37 2018

Roll src/third_party/catapult/ 883d59ef7..7b821dff5 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/883d59ef7027..7b821dff5984

$ git log 883d59ef7..7b821dff5 --date=short --no-merges --format='%ad %ae %s'
2018-04-05 dtu [pinpoint] Make "isolate not found" a fatal error.
2018-04-05 bsheedy Fix service starting on N and below

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:828190


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I2c2f761036fccbcdbe0d5ba25bb8e3f5666eb9f7
Reviewed-on: https://chromium-review.googlesource.com/998691
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548601}
[modify] https://crrev.com/23601295d37f6118c209684d27edbfff3c1da332/DEPS

Status: ExternalDependency (was: Assigned)
Marking this as an external dependency until the GVR bug that causes bad file descriptor crashes when the VrCore head tracking service is used gets fixed (b/77718627)
Labels: VR-Test
Components: Internals>XR
Removing Internals>VR component and assigning to Internals>XR
Components: -Internals>VR

Sign in to add a comment