New issue
Advanced search Search tips

Issue 828187 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Build-Toolchain



Sign in to add a comment

app-emulation/docker-runc fails to build with go-1.10

Project Member Reported by rahulchaudhry@chromium.org, Apr 2 2018

Issue description

With go-1.10 installed in the chroot, app-emulation/docker-runc fails to build with:

docker-runc-1.0.0_rc2_p20170308: x86_64-cros-linux-gnu-go build -i -ldflags "-X main.gitCommit=54296cf -X main.version=1.0.0-rc2" -tags "apparmor seccomp" -o runc .
docker-runc-1.0.0_rc2_p20170308: go build runtime/cgo: open /usr/lib/go/x86_64-cros-linux-gnu/pkg/linux_amd64/runtime/cgo.a: permission denied

For more details, see https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_toolchain/builds/1027

This ebuild should be using the cros-go eclass for building/installing Go packages.
See app-emulation/runc ebuild in chromiumos-overlay for example.

 
Cc: rkolchmeyer@google.com edjee@google.com mikewu@google.com
Steps to reproduce:

1. Cherry pick https://chromium-review.googlesource.com/947328 in chromiumos-overlay
2. sudo emerge dev-lang/go cross-x86_64-cros-linux-gnu/go
3. emerge-lakitu app-emulation/docker-runc

Comment 3 by mikewu@google.com, Apr 3 2018

Owner: mikewu@google.com
I see. Thanks for filing the bug! I will take a look at it.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/f3f9ec9fc3fe1c19d7986204d1b2df2efc736056

commit f3f9ec9fc3fe1c19d7986204d1b2df2efc736056
Author: Ke Wu <mikewu@google.com>
Date: Wed Apr 04 06:44:44 2018

lakitu: drop usgae of --install in docker-runc makefile

The "go build -i" invocation may slightly help with incremental
recompilation, but it will cause builds to fail if $GOROOT is not
writeable by the current user. For more details, see
https://github.com/docker/runc/commit/6581d0f488b3bfa00760cc71c5f1fccfee302b0d

TEST=emerge-lakitu app-emulation/docker-runc
BUG= chromium:828187 
RELEASE_NOTE=None

Change-Id: I90356a20fa42383f6120611f830c34e1ef5a208e
Reviewed-on: https://chromium-review.googlesource.com/994235
Commit-Ready: Ke Wu <mikewu@google.com>
Tested-by: Ke Wu <mikewu@google.com>
Reviewed-by: Daniel Wang <wonderfly@google.com>
Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org>

[rename] https://crrev.com/f3f9ec9fc3fe1c19d7986204d1b2df2efc736056/overlay-lakitu/app-emulation/docker-runc/docker-runc-1.0.0_rc2_p20170308-r2.ebuild
[modify] https://crrev.com/f3f9ec9fc3fe1c19d7986204d1b2df2efc736056/overlay-lakitu/app-emulation/docker-runc/files/1.0.0_rc2_p20170201-use-GO-cross-compiler.patch

Comment 5 by mikewu@google.com, Apr 4 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment