Verify boundary interface code works down to API 14 |
||||
Issue descriptionSince our support lib module is intended to compile for minSdk 14, we should also verify that the boundary interface code also works correctly on 14. For example, is it actually OK to catch ReflectiveOperationException [1] on devices below KITKAT (before ReflectiveOperationException was introduced). Also, we should double-check the minSdk for this folder and make sure it matches the minSdk for the webkit support lib module. If possible, we should explicitly state the minSdk for both (so that we can enforce they stay in-sync with each other). [1] https://cs.chromium.org/chromium/src/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/BoundaryInterfaceReflectionUtil.java?l=68&rcl=00216db2e577de165217b710b280754b2deb26a1
,
Apr 6 2018
Is there a way to specify the minSdk without an AndroidManifest?
,
Apr 6 2018
Not that I'm aware of, unfortunately
,
Apr 13 2018
So would we have to add an AndroidManifest to that folder or what do you suggest we do? :)
,
Apr 14 2018
I think AndroidManifest.xml is the easiest way.
,
May 11 2018
Not time critical, but important to add for code health. Also, I'll steal this because I've done similar work before.
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b701ea27efea3cd3481721806dd06f41e0759d17 commit b701ea27efea3cd3481721806dd06f41e0759d17 Author: Nate Fischer <ntfschr@chromium.org> Date: Tue Jun 19 19:29:14 2018 AW: lint: specify minSdkVersion for boundary interfaces No change to logic. This creates an AndroidManifest.xml file with only a minSdkVersion, which we use to configure lint to correctly verify the boundary interfaces compile down to the support library's minSdkVersion. This code will continue to only be called on >= 21 (Lollipop). R=torne@chromium.org Bug: 828184 Test: code compiles and passes lint Test: code doesn't compile with @TargetApi annotations in BoundaryInterfaceReflectionUtil Change-Id: I270f0f5732c1134ba77b912ece31cf188ee6cb5f Reviewed-on: https://chromium-review.googlesource.com/1105697 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568566} [add] https://crrev.com/b701ea27efea3cd3481721806dd06f41e0759d17/android_webview/support_library/boundary_interfaces/AndroidManifest.xml [modify] https://crrev.com/b701ea27efea3cd3481721806dd06f41e0759d17/android_webview/support_library/boundary_interfaces/BUILD.gn
,
Jun 19 2018
Mark as verified, because this bug itself is about verifying & enforcing something which already worked. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ntfschr@chromium.org
, Apr 4 2018