[MD Extensions] Runtime error thrown when visiting chrome://extensions/foo/bar.html |
|||
Issue descriptionThis is happening only with optimize_webui = true, and it is caused by invalid URL being requested (see screenshot). The fix is to specify a <base> path (similar to other WebUIs), see https://chromium-review.googlesource.com/c/chromium/src/+/991083.
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9741ff8ea55767f220ab17dafbb5f7c01b2ace41 commit 9741ff8ea55767f220ab17dafbb5f7c01b2ace41 Author: dpapad <dpapad@chromium.org> Date: Tue Apr 03 00:52:48 2018 MD Extensions: Specify <base href=...> in final bundled HTML file. With this change, the user is correctly forwarded to chrome://extensions, if an invalid URL is entered, for example chrome://extensions/foo/bar.html. Bug: 828174 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I18598c6b3367bcb972efda64bf56cdd1496f2ed7 Reviewed-on: https://chromium-review.googlesource.com/991083 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#547587} [modify] https://crrev.com/9741ff8ea55767f220ab17dafbb5f7c01b2ace41/chrome/browser/resources/md_extensions/BUILD.gn
,
Apr 3 2018
,
Apr 3 2018
Able to reproduce this issue on Windows 10, Mac OS 10.12.6 and Ubuntu 14.04 on the previous chrome builds and the issue is fixed on the latest Canary 67.0.3387.0. On navigating to a invalid URL chrome://extensions/foo/bar.html, getting forwarded to chrome://extensions page. Attached is the screen cast for reference. Hence adding TE verified labels as the fix is working as intended. Thanks.. |
|||
►
Sign in to add a comment |
|||
Comment 1 by dpa...@chromium.org
, Apr 2 2018