New issue
Advanced search Search tips

Issue 828147 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Add a method to set desktop startup ID in Aura shell.

Project Member Reported by timzheng@chromium.org, Apr 2 2018

Issue description

Design Doc: go/crostini-shelf

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/containers/sommelier/+/e094b4160d7f376584a565bf5881a7c8e6da079a

commit e094b4160d7f376584a565bf5881a7c8e6da079a
Author: David Reveman <reveman@chromium.org>
Date: Wed Apr 04 04:22:01 2018

Implement startup ID support.

This provides a basic gtk-shell protocol implementation on top of
aura-shell protocol. Startup IDs from gtk-shell are forwarded to
the aura shell.

_NET_STARTUP_ID property is also forwarded to aura-shell when using
X11 forwarding.

Bug:  828147 
Change-Id: Ic52fe446337608cf0318af4c121f5acdbf37a8c6
Reviewed-on: https://chromium-review.googlesource.com/992315
Tested-by: David Reveman <reveman@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>

[add] https://crrev.com/e094b4160d7f376584a565bf5881a7c8e6da079a/gtk-shell.xml
[modify] https://crrev.com/e094b4160d7f376584a565bf5881a7c8e6da079a/sommelier.c
[modify] https://crrev.com/e094b4160d7f376584a565bf5881a7c8e6da079a/Makefile
[modify] https://crrev.com/e094b4160d7f376584a565bf5881a7c8e6da079a/aura-shell.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08df566dba67a476a2439dd5c846a8ed285f067f

commit 08df566dba67a476a2439dd5c846a8ed285f067f
Author: Tim Zheng <timzheng@google.com>
Date: Wed Apr 04 05:08:15 2018

Add a method to set startup ID in Aura shell.

A new method is added to the Aura shell interface. When client call this
method, the startup ID is set as a property on the Aura window.
This is going to be used to identify a specific virtual machine
applications that a window is for.

TEST: still compile.
Bug:  828147 
Change-Id: If86547f4a58ca7793887acfdbb7f6eb0036bf761
Reviewed-on: https://chromium-review.googlesource.com/990791
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547985}
[modify] https://crrev.com/08df566dba67a476a2439dd5c846a8ed285f067f/components/exo/shell_surface_base.cc
[modify] https://crrev.com/08df566dba67a476a2439dd5c846a8ed285f067f/components/exo/shell_surface_base.h
[modify] https://crrev.com/08df566dba67a476a2439dd5c846a8ed285f067f/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/08df566dba67a476a2439dd5c846a8ed285f067f/components/exo/sub_surface.h
[modify] https://crrev.com/08df566dba67a476a2439dd5c846a8ed285f067f/components/exo/surface.cc
[modify] https://crrev.com/08df566dba67a476a2439dd5c846a8ed285f067f/components/exo/surface.h
[modify] https://crrev.com/08df566dba67a476a2439dd5c846a8ed285f067f/components/exo/surface_delegate.h
[modify] https://crrev.com/08df566dba67a476a2439dd5c846a8ed285f067f/components/exo/surface_tree_host.h
[modify] https://crrev.com/08df566dba67a476a2439dd5c846a8ed285f067f/components/exo/wayland/aura-shell-client-protocol.h
[modify] https://crrev.com/08df566dba67a476a2439dd5c846a8ed285f067f/components/exo/wayland/aura-shell-protocol.c
[modify] https://crrev.com/08df566dba67a476a2439dd5c846a8ed285f067f/components/exo/wayland/aura-shell-server-protocol.h
[modify] https://crrev.com/08df566dba67a476a2439dd5c846a8ed285f067f/components/exo/wayland/protocol/aura-shell.xml
[modify] https://crrev.com/08df566dba67a476a2439dd5c846a8ed285f067f/components/exo/wayland/server.cc

Components: OS>Systems>Containers
Labels: Hotlist-Crostini-UI
Status: Fixed (was: Assigned)

Comment 6 by vapier@chromium.org, May 23 2018

Labels: -Restrict-View-Google

Sign in to add a comment