New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 828119 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Task



Sign in to add a comment

Handle format conversion in VaapiJpegDecodeAccelerator::OutputPicture

Project Member Reported by ddavenp...@chromium.org, Apr 2 2018

Issue description

In VaapiJpegDecodeAccelerator::OutputPicture, vaGetImage is called (via vaapi_wrapper_->GetVaImage) with the format set to I420. Some platforms may not support I420.

Chrome should handle this case, and do a format conversion where sensible.

This is already done for V4L2JDA using libyuv.
 
Status: Available (was: Untriaged)
Cc: dcasta...@chromium.org
Labels: -Type-Feature Type-Task
Isn't 420 supported almost everywhere in practice?
Cc: mcasas@chromium.org andrescj@chromium.org
I420 is supported for compositing everywhere, but not for scanout (we have NV12 there though), I'm not familiar with VaapiJpegDecodeAccelerator but I'd assume it can probably output NV12, and I'd suggest to use that if possible.

CCing Miguel and Andres that might know more.
After decoding MJPEG frame data surface will contain data from which MJPEG was encoded, mostly YUV422 in case from camera O/P and VaapiJpegDecodeAccelerator::OutputPicture set output format as I420.

Expectation from vaGetimage doesn’t seems correct here. VaGetImage could return INVALID_FORMAT in such case. 

Basically chromium browser should take this independent of how a particular hardware is handling the conversion to I420
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62a0b27763707842e3388bfa2663b87018657b49

commit 62a0b27763707842e3388bfa2663b87018657b49
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Thu Apr 12 06:27:14 2018

media/gpu/vaapi: Disable H264 HW encode and MJPEG decode on StoneyRidge

BUG=b:76445849,  chromium:828119 ,  chromium:828482
TEST=jpeg_decode_accelerator_unittest and video_encode_accelerator_unittest on StoneyRidge device

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifa61026390fe31e88e0929257a521745e9a72fad
Reviewed-on: https://chromium-review.googlesource.com/983334
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550049}
[modify] https://crrev.com/62a0b27763707842e3388bfa2663b87018657b49/media/gpu/vaapi/va.sigs
[modify] https://crrev.com/62a0b27763707842e3388bfa2663b87018657b49/media/gpu/vaapi/vaapi_wrapper.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cfbc0db38b615cef3fd82ad321673e7e262796a8

commit cfbc0db38b615cef3fd82ad321673e7e262796a8
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Fri Apr 13 06:10:56 2018

avtest_label_detect: Disable HW H264 encoding and JPEG decoding on AMD StoneyRidge

Chrome doesn't support HW H264 encoding and JPEG decoding on AMD StoneyRidge
because of https://crbug.com/828482 and  https://crbug.com/828119 .

BUG=b:76445849, b:77499495,  chromium:828119 , chromium:828482
TEST=avtest_label_detect

Change-Id: Ic8a8b7839df8604cf423772ccb4c8db0f65fd7b4
Reviewed-on: https://chromium-review.googlesource.com/1004078
Commit-Ready: Hirokazu Honda <hiroh@chromium.org>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Tested-by: Deepak Sharma <deepak.sharma@amd.com>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Deepak Sharma <deepak.sharma@amd.com>

[modify] https://crrev.com/cfbc0db38b615cef3fd82ad321673e7e262796a8/avtest_label_detect/util_vaapi.c

Owner: posciak@chromium.org
Cc: posciak@chromium.org
Owner: dstaessens@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14b7e6ab0515c1fa7534a6931a161abd6ca87b75

commit 14b7e6ab0515c1fa7534a6931a161abd6ca87b75
Author: David Staessens <dstaessens@chromium.org>
Date: Mon Aug 06 07:55:22 2018

Added support for checking supported image formats to the VAAPI wrapper.

Currently the jpeg decoder always assumes the VAAPI will support decoding to the
I420 format. As this might not be the case for all VAAPI implementations this
change adds a method to the VAAPI wrapper to check whether a specific format is
supported.

Bug:  828119 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8ad54a27b9e1d560f5590ae778e43f8d75bba8e9
Reviewed-on: https://chromium-review.googlesource.com/1102277
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580817}
[modify] https://crrev.com/14b7e6ab0515c1fa7534a6931a161abd6ca87b75/media/gpu/vaapi/va.sigs
[modify] https://crrev.com/14b7e6ab0515c1fa7534a6931a161abd6ca87b75/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.cc
[modify] https://crrev.com/14b7e6ab0515c1fa7534a6931a161abd6ca87b75/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.h
[modify] https://crrev.com/14b7e6ab0515c1fa7534a6931a161abd6ca87b75/media/gpu/vaapi/vaapi_wrapper.cc
[modify] https://crrev.com/14b7e6ab0515c1fa7534a6931a161abd6ca87b75/media/gpu/vaapi/vaapi_wrapper.h

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9359ec33ad5324b63f65dc99eb9b884878b2ad3f

commit 9359ec33ad5324b63f65dc99eb9b884878b2ad3f
Author: David Staessens <dstaessens@chromium.org>
Date: Thu Sep 20 00:59:59 2018

media/gpu/VAAPI: JPEG decode tests fixed when decoder output format is not I420.

The VAAPI JPEG decoder on some platforms won't convert the decoded images to the
I420 format, but will return the decoded images in the JPEG's pixel format. This
change adapts the VaapiJpegDecodeAcceleratorTest to work correctly when no
conversion is done.

Additional cleanup:
* Made a few member functions const.

TEST=ran JDA tests on eve and grunt

Bug:  828119 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I715c5e88b8fa3c3d4db7a69a4e195d2ef3f79d8a
Reviewed-on: https://chromium-review.googlesource.com/1218486
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592641}
[modify] https://crrev.com/9359ec33ad5324b63f65dc99eb9b884878b2ad3f/media/gpu/vaapi/vaapi_jpeg_decode_accelerator_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/900c2b4d5276e8207a0f1483c36b6b3747ec59c6

commit 900c2b4d5276e8207a0f1483c36b6b3747ec59c6
Author: David Staessens <dstaessens@chromium.org>
Date: Thu Sep 20 04:34:21 2018

media/gpu/VAAPI: Add JPEG decode test using different sampling formats.

The VAAPI JPEG decoder on some platforms won't convert the decoded images to the
I420 format, but will return the decoded images in their original pixel format.
This means a conversion must be done in the VAAPI wrapper to the expected I420
output format. This change adds a SamplingFormatChange test that will test
whether the conversion is successful for JPEGS with different sampling formats.

Additional cleanup:
* Added some comments for clarification

TEST=ran JDA tests on eve and grunt

Bug:  828119 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibade43422590268d774b8d330097e46a8a33bca1
Reviewed-on: https://chromium-review.googlesource.com/1218386
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592683}
[modify] https://crrev.com/900c2b4d5276e8207a0f1483c36b6b3747ec59c6/media/gpu/jpeg_decode_accelerator_unittest.cc
[modify] https://crrev.com/900c2b4d5276e8207a0f1483c36b6b3747ec59c6/ui/gfx/codec/jpeg_codec.cc
[modify] https://crrev.com/900c2b4d5276e8207a0f1483c36b6b3747ec59c6/ui/gfx/codec/jpeg_codec.h

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f92d8cecca74b4854ba1b6450d64a337a8961fe

commit 3f92d8cecca74b4854ba1b6450d64a337a8961fe
Author: David Staessens <dstaessens@chromium.org>
Date: Wed Oct 10 23:20:59 2018

media/gpu/VAAPI: Fix HW JPEG decode tests on Grunt.

Slightly increased the maximum allowed difference between HW and SW decode. On
Grunt the difference between HW and SW decode is slightly higher than on other
platforms, even though visually the images look identical.

Adapted ScopedVAImage and BadScopedVAImage tests to use the I420 format. Grunt
will always return a decoded image in its source chroma sampling format. But
these tests don't do any actual decoding, it this case only fetching the image
in the I420 format seems to work.

TEST=ran JDA tests on eve and grunt

Bug:  828119 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4598d78702e59f4759dab37a5a1ea49b7229b4cc
Reviewed-on: https://chromium-review.googlesource.com/c/1249283
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598562}
[modify] https://crrev.com/3f92d8cecca74b4854ba1b6450d64a337a8961fe/media/gpu/jpeg_decode_accelerator_unittest.cc
[modify] https://crrev.com/3f92d8cecca74b4854ba1b6450d64a337a8961fe/media/gpu/vaapi/vaapi_jpeg_decode_accelerator_unittest.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f745446f24a398586a150ae324cb2cf0a97cb808

commit f745446f24a398586a150ae324cb2cf0a97cb808
Author: David Staessens <dstaessens@chromium.org>
Date: Wed Oct 10 23:47:10 2018

media/gpu/VAAPI: Convert output image to I420 when performing HW JPEG decode.

Not all JPEG HW decoders support fetching a decoded image in the I420 format.
This change allows enabling HW JPEG decoding on platforms that don't support
fetching a decoded image in the I420 format.

TEST=ran JDA tests on eve and grunt

Bug:  828119 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5e614f7b15c03a6b9966ce365c12450af2125aa6
Reviewed-on: https://chromium-review.googlesource.com/c/1119742
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598575}
[modify] https://crrev.com/f745446f24a398586a150ae324cb2cf0a97cb808/media/gpu/jpeg_decode_accelerator_unittest.cc
[modify] https://crrev.com/f745446f24a398586a150ae324cb2cf0a97cb808/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.cc
[modify] https://crrev.com/f745446f24a398586a150ae324cb2cf0a97cb808/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.h
[modify] https://crrev.com/f745446f24a398586a150ae324cb2cf0a97cb808/media/gpu/vaapi/vaapi_jpeg_decode_accelerator_unittest.cc

Thanks for making this happen!
Are we going to enable HW JPEG decoding on stnyridge devoces from M71?
Then, we need to cherry-pick these CLs to M71.
Though, it is definitely better to see test results and make sure they works correctly.
This is intended to make it into M71. All code required for the output conversion is in M71. Unfortunately there was a memory issue in libva, the fix didn't make it into M71, so I couldn't enable HW JPEG decode yet.

I'm currently checking in the CL's required to enable HW JPEG decode on Grunt. When that is done I will check in the CL's to enable autotests. If all that is done we can start cherry picking:
- crrev.com/c/1274172 fixes the memory issue in libva
- crrev.com/c/1256462 enables HW JPEG decoding in Chrome
- crrev.com/c/1272757 and crrev.com/c/1272835 enable autotests

Project Member

Comment 16 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fd4b78a787129ec952da757b4195ebc81e37c57

commit 5fd4b78a787129ec952da757b4195ebc81e37c57
Author: David Staessens <dstaessens@chromium.org>
Date: Mon Oct 15 03:37:28 2018

media/gpu/VAAPI: Enable HW JPEG decoding on Grunt.

This change removes the "Mesa Gallium driver" from the blacklist in the vaapi
JPEG decoder.

TEST=ran VDA tests on Grunt

Bug:  828119 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1100cbebcc7f2a2eca3c6109fa120db764543a95
Reviewed-on: https://chromium-review.googlesource.com/c/1256462
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599559}
[modify] https://crrev.com/5fd4b78a787129ec952da757b4195ebc81e37c57/media/gpu/vaapi/vaapi_wrapper.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/28b2603ff5048946b89284b7294b8503e89dd9cf

commit 28b2603ff5048946b89284b7294b8503e89dd9cf
Author: David Staessens <dstaessens@chromium.org>
Date: Wed Oct 17 21:23:19 2018

Added HW JPEG decode to Stoney Ridge capabilities.

TEST=Ran avtest_label_detect and video_VideoCapability on Grunt
CQ-DEPEND=CL:1272835

BUG= chromium:828119 
Change-Id: Ieb7801a4c64aedd54c78dd0fc10366c89ac506c1
Reviewed-on: https://chromium-review.googlesource.com/1272757
Commit-Ready: Drew Davenport <ddavenport@chromium.org>
Tested-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

[modify] https://crrev.com/28b2603ff5048946b89284b7294b8503e89dd9cf/chipset-stnyridge/chromeos-base/autotest-capability-chipset-stnyridge/files/15-chipset-stnyridge-capabilities.yaml

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7d8b0f2e63682d3bc7638d187381bc0889926f6a

commit 7d8b0f2e63682d3bc7638d187381bc0889926f6a
Author: David Staessens <dstaessens@chromium.org>
Date: Wed Oct 17 21:23:18 2018

Removed HW JPEG decode on Stoney Ridge from blacklist.

TEST=Ran avtest_label_detect and video_VideoCapability on Grunt
CQ-DEPEND=CL:1272757

BUG= chromium:828119 
Change-Id: I1f10878c86c87179977bf78b97f042a34cf3c000
Reviewed-on: https://chromium-review.googlesource.com/1272835
Commit-Ready: Drew Davenport <ddavenport@chromium.org>
Tested-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

[modify] https://crrev.com/7d8b0f2e63682d3bc7638d187381bc0889926f6a/avtest_label_detect/util_vaapi.c

Labels: -Pri-3 Pri-1
The last three CL's submitted in this bug should be merged to R71, to activate HW JPEG decoding on Grunt (b/114120453).
All required code and fixes are already in R71. These CL's only activate the capabilities and tests, but didn't make it in in time for the branch.
* Chrome: crrev.com/c/1256462 enables HW JPEG decoding on Grunt.
* ChromeOS: crrev.com/c/1272757 and crrev.com/c/1272835 enable HW JPEG decode autotests on Grunt.
Labels: Merge-Request-71
Project Member

Comment 21 by sheriffbot@chromium.org, Oct 20

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 23

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18d840da3a13c7de36db2dbd9ea4447b840a1f76

commit 18d840da3a13c7de36db2dbd9ea4447b840a1f76
Author: David Staessens <dstaessens@chromium.org>
Date: Tue Oct 23 02:21:37 2018

media/gpu/VAAPI: Enable HW JPEG decoding on Grunt.

This change removes the "Mesa Gallium driver" from the blacklist in the vaapi
JPEG decoder.

TEST=ran VDA tests on Grunt

Bug:  828119 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1100cbebcc7f2a2eca3c6109fa120db764543a95
Reviewed-on: https://chromium-review.googlesource.com/c/1256462
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599559}(cherry picked from commit 5fd4b78a787129ec952da757b4195ebc81e37c57)
Reviewed-on: https://chromium-review.googlesource.com/c/1295610
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#255}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/18d840da3a13c7de36db2dbd9ea4447b840a1f76/media/gpu/vaapi/vaapi_wrapper.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/18d840da3a13c7de36db2dbd9ea4447b840a1f76

Commit: 18d840da3a13c7de36db2dbd9ea4447b840a1f76
Author: dstaessens@chromium.org
Commiter: acourbot@chromium.org
Date: 2018-10-23 02:21:37 +0000 UTC

media/gpu/VAAPI: Enable HW JPEG decoding on Grunt.

This change removes the "Mesa Gallium driver" from the blacklist in the vaapi
JPEG decoder.

TEST=ran VDA tests on Grunt

Bug:  828119 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1100cbebcc7f2a2eca3c6109fa120db764543a95
Reviewed-on: https://chromium-review.googlesource.com/c/1256462
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599559}(cherry picked from commit 5fd4b78a787129ec952da757b4195ebc81e37c57)
Reviewed-on: https://chromium-review.googlesource.com/c/1295610
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#255}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 24 by bugdroid1@chromium.org, Oct 25

Labels: merge-merged-release-R71-11151.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/67fefa146ba9ac661d78612715429dd1dcc2b1f4

commit 67fefa146ba9ac661d78612715429dd1dcc2b1f4
Author: David Staessens <dstaessens@chromium.org>
Date: Thu Oct 25 03:54:16 2018

Removed HW JPEG decode on Stoney Ridge from blacklist.

TEST=Ran avtest_label_detect and video_VideoCapability on Grunt
CQ-DEPEND=CL:1272757

BUG= chromium:828119 
Change-Id: I1f10878c86c87179977bf78b97f042a34cf3c000
Reviewed-on: https://chromium-review.googlesource.com/1272835
Commit-Ready: Drew Davenport <ddavenport@chromium.org>
Tested-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
(cherry picked from commit 7d8b0f2e63682d3bc7638d187381bc0889926f6a)
Reviewed-on: https://chromium-review.googlesource.com/c/1298515
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>

[modify] https://crrev.com/67fefa146ba9ac661d78612715429dd1dcc2b1f4/avtest_label_detect/util_vaapi.c

Project Member

Comment 25 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/83af1dc43ba890cc7fc83d7a9b6ba0c339b33399

commit 83af1dc43ba890cc7fc83d7a9b6ba0c339b33399
Author: David Staessens <dstaessens@chromium.org>
Date: Thu Oct 25 03:54:17 2018

Added HW JPEG decode to Stoney Ridge capabilities.

TEST=Ran avtest_label_detect and video_VideoCapability on Grunt
CQ-DEPEND=CL:1272835

BUG= chromium:828119 
Change-Id: Ieb7801a4c64aedd54c78dd0fc10366c89ac506c1
Reviewed-on: https://chromium-review.googlesource.com/1272757
Commit-Ready: Drew Davenport <ddavenport@chromium.org>
Tested-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
(cherry picked from commit b7d9573554376c16056178663e04b2f694f9dea3)
Reviewed-on: https://chromium-review.googlesource.com/c/1297812
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>

[modify] https://crrev.com/83af1dc43ba890cc7fc83d7a9b6ba0c339b33399/chipset-stnyridge/chromeos-base/autotest-capability-chipset-stnyridge/files/15-chipset-stnyridge-capabilities.yaml

Status: Verified (was: Assigned)
Project Member

Comment 27 by bugdroid1@chromium.org, Nov 14

Labels: merge-merged-firmware-grunt-11031.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/d4773c30c0cd64c56af47580238ca18666163b84

commit d4773c30c0cd64c56af47580238ca18666163b84
Author: David Staessens <dstaessens@chromium.org>
Date: Wed Nov 14 19:13:20 2018

Added HW JPEG decode to Stoney Ridge capabilities.

TEST=Ran avtest_label_detect and video_VideoCapability on Grunt
CQ-DEPEND=CL:1272835

BUG= chromium:828119 
Change-Id: Ieb7801a4c64aedd54c78dd0fc10366c89ac506c1
Reviewed-on: https://chromium-review.googlesource.com/1272757
Commit-Ready: Drew Davenport <ddavenport@chromium.org>
Tested-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1335991
Reviewed-by: Martin Roth <martinroth@chromium.org>
Tested-by: Martin Roth <martinroth@chromium.org>

[modify] https://crrev.com/d4773c30c0cd64c56af47580238ca18666163b84/chipset-stnyridge/chromeos-base/autotest-capability-chipset-stnyridge/files/15-chipset-stnyridge-capabilities.yaml

Sign in to add a comment