MacViews menu cosmetics |
||
Issue descriptionFrom sdy: 1) Menus don't fade out on close 2) Menu items don't blink on click 3) Submenus don't disappear when you move the mouse vertically 4) Click and hold doesn't keep menus open - letting go after a hold should close them 5) Border of 1px around items/separators/etc should not be there 6) Symbols for Esc/Backspace are missing 7) Edit/zoom button items are odd 8) Minor text should be black & full size 9) Typing doesn't search menus by prefix
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e2cfd4d7a7aed99a4306b47a3a588186f054ff7 commit 4e2cfd4d7a7aed99a4306b47a3a588186f054ff7 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Apr 03 20:03:12 2018 views: reduce mac menu border margin Mac menus don't use a margin around the contents at all - the menu items (especially their highlights) draw hard up to the menu edge. TBR=sky@chromium.org Bug: 828117 Change-Id: I0165bc8987d0f7d6c1ba29660098f91ad9478984 Reviewed-on: https://chromium-review.googlesource.com/993418 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#547800} [modify] https://crrev.com/4e2cfd4d7a7aed99a4306b47a3a588186f054ff7/ui/views/controls/menu/menu_config_mac.mm
,
Apr 5 2018
I'm obsoleting this bug: I got in touch with UX about whether we should continue working down this list or adopt a distinctive design, and UX would strongly prefer a distinctive design. I've just gotten specs for same, so I'll be implementing those instead of continuing work here.
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d502ddfc3c886f22c0abf0603bca1bc322f1611 commit 1d502ddfc3c886f22c0abf0603bca1bc322f1611 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Apr 10 02:24:37 2018 ui: support Mac menu symbols for shortcuts A previous change added support for Mac modifier symbols; this change adds support for the base shortcut characters to use symbols. The list here is taken from Apple's list of keyboard shortcut symbols. Bug: 828117 Change-Id: I9d10e3462f757106442a03ae762fe0e954bb45eb Reviewed-on: https://chromium-review.googlesource.com/996036 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#549383} [modify] https://crrev.com/1d502ddfc3c886f22c0abf0603bca1bc322f1611/ui/base/accelerators/accelerator.cc [modify] https://crrev.com/1d502ddfc3c886f22c0abf0603bca1bc322f1611/ui/base/accelerators/accelerator.h |
||
►
Sign in to add a comment |
||
Comment 1 by ellyjo...@chromium.org
, Apr 2 2018