New issue
Advanced search Search tips

Issue 828113 link

Starred by 1 user
Status: Fixed
Owner:
bajones@chromium.org
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 2
Type: Bug
Proj-XR



Sign in to add a comment

Ensure WebXR values that alter rendering only take effect on frame boundaries.

Project Member Reported by bajones@chromium.org, Apr 2 2018 
Several values in WebXR can be updated at any time but should only take effect on the next frame. This is to ensure frame integrity by making sure that all rendering for a single frame is done with a consistent set of values. The attributes in question are:

XRSession.depthNear
XRSession.depthFar
XRSession.baseLayer
XRWebGLLayer.requestViewportScaling()
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/281d3a855dc62830fdf8a43628f1313bfd371737

commit 281d3a855dc62830fdf8a43628f1313bfd371737
Author: Brandon Jones <bajones@chromium.org>
Date: Mon Apr 02 23:00:16 2018

Ensure WebXR value changes take effect the following frame.

Ensures that the developer can't alter viewports or projection matrices
mid-frame. Covers:

XRSession.depthNear
XRSession.depthFar
XRWebGLLayer.requestViewportScaling()

Bug:  828113 
Change-Id: If61262fafaf497a2231b9a57eefa4dd6dbb481eb
Reviewed-on: https://chromium-review.googlesource.com/990719
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547547}
[modify] https://crrev.com/281d3a855dc62830fdf8a43628f1313bfd371737/third_party/WebKit/LayoutTests/xr/xrView_oneframeupdate.html
[add] https://crrev.com/281d3a855dc62830fdf8a43628f1313bfd371737/third_party/WebKit/LayoutTests/xr/xrWebGLLayer_viewport_scale.html
[modify] https://crrev.com/281d3a855dc62830fdf8a43628f1313bfd371737/third_party/WebKit/Source/modules/xr/XRSession.cpp
[modify] https://crrev.com/281d3a855dc62830fdf8a43628f1313bfd371737/third_party/WebKit/Source/modules/xr/XRSession.h
[modify] https://crrev.com/281d3a855dc62830fdf8a43628f1313bfd371737/third_party/WebKit/Source/modules/xr/XRWebGLLayer.cpp
[modify] https://crrev.com/281d3a855dc62830fdf8a43628f1313bfd371737/third_party/WebKit/Source/modules/xr/XRWebGLLayer.h

Comment 2 by bajones@chromium.org, Apr 2 2018

Status: Fixed (was: Started)

Comment 3 by dougman@chromium.org, May 8 2018

Labels: Test-Complete

Comment 4 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR
►

Sign in to add a comment