ICC file ignored if EDID produces a correct gfx::ColorSpace |
|||
Issue descriptionBecause of line [1] [1] https://cs.chromium.org/chromium/src/ash/display/display_color_manager.cc?type=cs&l=179
,
Apr 3 2018
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cffe98abea3b4f08c3349af686ed146932cd4c4 commit 0cffe98abea3b4f08c3349af686ed146932cd4c4 Author: Miguel Casas <mcasas@chromium.org> Date: Wed Apr 04 23:16:18 2018 CrOs display: reenable loading ICC file if present crrev.com/c/728325 disabled fetching/using an ICC file for display color correction if enough information was available in the monitor EDID. This was based on the wrong assumption that either one or the other would be present, but not both. This CL reenables the use of (download of) the ICC file for monitor colorimetry, using the EDID provided info as a fallback. On the implementation: DisplayConfigurator::NotifyDisplayStateObservers() pings DisplayColorManager when there's new Display info. The later calls ApplyDisplayColorCalibration() directly or after fetching the ICC file. In either case, if all steps succeed, SetColorCorrection() is called; at this step we are sure that the found/downloaded ICC file is good, and we can remove the usage of the EDID provided ColorSpace. Bug: 828102 Change-Id: Id799f8412ea06d781712884b1d02694f124860c6 Reviewed-on: https://chromium-review.googlesource.com/990494 Reviewed-by: Greg Levin <glevin@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#548238} [modify] https://crrev.com/0cffe98abea3b4f08c3349af686ed146932cd4c4/ash/display/display_color_manager.cc [modify] https://crrev.com/0cffe98abea3b4f08c3349af686ed146932cd4c4/ui/display/manager/chromeos/display_configurator.cc [modify] https://crrev.com/0cffe98abea3b4f08c3349af686ed146932cd4c4/ui/display/types/display_snapshot.h
,
Apr 5 2018
#3 Commit 0cffe98a... initially landed in 67.0.3389.0 Marking as Fixed, please verify in ~2 weeks or so.
,
Apr 9 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mcasas@chromium.org
, Apr 2 2018