New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 828102 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ICC file ignored if EDID produces a correct gfx::ColorSpace

Project Member Reported by mcasas@chromium.org, Apr 2 2018

Issue description

This is the external version of b/76023957.
Cc: afakhry@chromium.org dcasta...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cffe98abea3b4f08c3349af686ed146932cd4c4

commit 0cffe98abea3b4f08c3349af686ed146932cd4c4
Author: Miguel Casas <mcasas@chromium.org>
Date: Wed Apr 04 23:16:18 2018

CrOs display: reenable loading ICC file if present

crrev.com/c/728325 disabled fetching/using an ICC file for display color
correction if enough information was available in the monitor EDID. This
was based on the wrong assumption that either one or the other would be
present, but not both.  This CL reenables the use of (download of) the ICC
file for monitor colorimetry, using the EDID provided info as a fallback.

On the implementation:
DisplayConfigurator::NotifyDisplayStateObservers() pings DisplayColorManager
when there's new Display info. The later calls ApplyDisplayColorCalibration()
directly or after fetching the ICC file. In either case, if all steps
succeed, SetColorCorrection() is called; at this step we are sure that the
found/downloaded ICC file is good, and we can remove the usage of the EDID
provided ColorSpace.

Bug:  828102 
Change-Id: Id799f8412ea06d781712884b1d02694f124860c6
Reviewed-on: https://chromium-review.googlesource.com/990494
Reviewed-by: Greg Levin <glevin@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548238}
[modify] https://crrev.com/0cffe98abea3b4f08c3349af686ed146932cd4c4/ash/display/display_color_manager.cc
[modify] https://crrev.com/0cffe98abea3b4f08c3349af686ed146932cd4c4/ui/display/manager/chromeos/display_configurator.cc
[modify] https://crrev.com/0cffe98abea3b4f08c3349af686ed146932cd4c4/ui/display/types/display_snapshot.h

NextAction: 2018-04-20
Status: Fixed (was: Started)
#3  Commit 0cffe98a... initially landed in 67.0.3389.0

Marking as Fixed, please verify in ~2 weeks or so.
NextAction: ----
Status: Verified (was: Fixed)
Verified in b/76023957

Sign in to add a comment