New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 828088 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove boolean |is_success| parameter from FidoHidDevice::MessageReceived

Project Member Reported by hongjunchoi@chromium.org, Apr 2 2018

Issue description

Failure cases could be represented by nullptr response. 
 
Status: Available (was: Untriaged)
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69de77e10a318290833422f7deed5d5c70e76a7b

commit 69de77e10a318290833422f7deed5d5c70e76a7b
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Wed Apr 18 18:01:24 2018

Refactor FidoHidDevice::MessageReceived()

|is_success| parameter in FidoHidDevice::MessageReceived() can be
represented by nullptr |message| parameter.

Bug:  828088 
Change-Id: Ia13439acc98f43af1741308063ac7c2ab1b62af9
Reviewed-on: https://chromium-review.googlesource.com/1014655
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551741}
[modify] https://crrev.com/69de77e10a318290833422f7deed5d5c70e76a7b/device/fido/fido_hid_device.cc
[modify] https://crrev.com/69de77e10a318290833422f7deed5d5c70e76a7b/device/fido/fido_hid_device.h
[modify] https://crrev.com/69de77e10a318290833422f7deed5d5c70e76a7b/device/fido/fido_hid_message.cc
[modify] https://crrev.com/69de77e10a318290833422f7deed5d5c70e76a7b/device/fido/fido_hid_message.h
[modify] https://crrev.com/69de77e10a318290833422f7deed5d5c70e76a7b/device/fido/fido_hid_message_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment