Remove boolean |is_success| parameter from FidoHidDevice::MessageReceived |
|||
Issue descriptionFailure cases could be represented by nullptr response.
,
Apr 16 2018
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69de77e10a318290833422f7deed5d5c70e76a7b commit 69de77e10a318290833422f7deed5d5c70e76a7b Author: Jun Choi <hongjunchoi@chromium.org> Date: Wed Apr 18 18:01:24 2018 Refactor FidoHidDevice::MessageReceived() |is_success| parameter in FidoHidDevice::MessageReceived() can be represented by nullptr |message| parameter. Bug: 828088 Change-Id: Ia13439acc98f43af1741308063ac7c2ab1b62af9 Reviewed-on: https://chromium-review.googlesource.com/1014655 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551741} [modify] https://crrev.com/69de77e10a318290833422f7deed5d5c70e76a7b/device/fido/fido_hid_device.cc [modify] https://crrev.com/69de77e10a318290833422f7deed5d5c70e76a7b/device/fido/fido_hid_device.h [modify] https://crrev.com/69de77e10a318290833422f7deed5d5c70e76a7b/device/fido/fido_hid_message.cc [modify] https://crrev.com/69de77e10a318290833422f7deed5d5c70e76a7b/device/fido/fido_hid_message.h [modify] https://crrev.com/69de77e10a318290833422f7deed5d5c70e76a7b/device/fido/fido_hid_message_unittest.cc
,
Apr 18 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by engedy@chromium.org
, Apr 3 2018