New issue
Advanced search Search tips

Issue 828076 link

Starred by 1 user
Status: Assigned
Owner:
kozy@chromium.org
Cc:
yangguo@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Breakpoints set with debug() behave inconsistently on reload.

Project Member Reported by yangguo@chromium.org, Apr 2 2018 
See https://twitter.com/bradleymeck/status/980163040216780800

Functions that have a debug break set via debug() on the console do not show up in the breakpoint list. They also persist on reload if the same V8 isolate is reused.

They should show up in the breakpoint list so that it is easy to confirm whether they are set, and also as an easy way to clear.

Alexey, I'm not familiar with the code around this. I would really appreciate if you could fix this.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f2b5a6da4e7db882e6dca364417b5858fa782345

commit f2b5a6da4e7db882e6dca364417b5858fa782345
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon Apr 23 20:36:47 2018

[inspector] added Debugger.setBreakpointOnFunctionCall

This function can be used to set breakpoint on any function call,
including native functions without source code, for them new method is
only one way to set breakpoint.

R=dgozman@chromium.org

Bug: chromium:828076
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iae8f4805b6e860a7ca008041fdfbe75e43a1959c
Reviewed-on: https://chromium-review.googlesource.com/1023128
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52745}
[modify] https://crrev.com/f2b5a6da4e7db882e6dca364417b5858fa782345/src/inspector/js_protocol.json
[modify] https://crrev.com/f2b5a6da4e7db882e6dca364417b5858fa782345/src/inspector/js_protocol.pdl
[modify] https://crrev.com/f2b5a6da4e7db882e6dca364417b5858fa782345/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/f2b5a6da4e7db882e6dca364417b5858fa782345/src/inspector/v8-debugger-agent-impl.h
[add] https://crrev.com/f2b5a6da4e7db882e6dca364417b5858fa782345/test/inspector/debugger/set-breakpoint-on-function-call-expected.txt
[add] https://crrev.com/f2b5a6da4e7db882e6dca364417b5858fa782345/test/inspector/debugger/set-breakpoint-on-function-call.js

Comment 2 by kozy@chromium.org, May 2 2018

Owner: kozy@chromium.org
►

Sign in to add a comment