New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 828062 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

mus_unit_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 2 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of cmumford@chromium.org

mus_unit_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Builders failed on: 
- Linux Chromium OS ASan LSan Tests (1): 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29

CFI tests failing on both Linux and Android:

BookmarkLastVisitUpdaterTest.IsNotTrackingIncognitoVisits
BookmarkLastVisitUpdaterTest.IsTrackingVisits
BookmarkLastVisitUpdaterTest.DoesNotCrashForNoBookmarkModel
 
Owner: arthurso...@chromium.org
Identified (hopefully) the candidate by manual `git bisect`. Reverted https://chromium-review.googlesource.com/c/chromium/src/+/990314.

arthursonzogni@ assigning to you as you are the author of crrev.com/c/990314. If I have incorrectly identified your CL as the actual cause please assign this bug to me and accept my apologies for reverting your change.

Comment 2 by jam@chromium.org, Apr 2 2018

Cc: nasko@chromium.org
Thanks Chris for tracking this down. I'll take a look and see if there's a quick fix, as this is a test-only issue and a bunch of work depends on this launching.

Comment 3 by jam@chromium.org, Apr 2 2018

I have a fix for the CFI issue.

The LSAN bot is a different bug. It also started failing at 547259, while Arthur's patch is at 547350

Comment 4 by jam@chromium.org, Apr 2 2018

(I'll try to bisect the lsan issue now)

Comment 5 by jam@chromium.org, Apr 2 2018

and Chris already fixed the lsan issue by reverting https://chromium.googlesource.com/chromium/src/+/11df4514ddd778370c2316a3acb1b6da772d5291 :)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39d5daaa736c7a127121b6b91dc1254177948a7b

commit 39d5daaa736c7a127121b6b91dc1254177948a7b
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Apr 02 21:31:41 2018

Fix bad cast from ResourceContext to ProfileIOData in ChromeContentBrowserClient.

In unit tests, this isn't true as the object is a MockResourceContext. For now the quick fix is to check for the safe browsing service being available before trying to add its throttle, as it isn't set in unit tests.

Bug:  828062 
Change-Id: Ibb2d65307b72f02fe1e0de27797ca834f01cb184
Reviewed-on: https://chromium-review.googlesource.com/990724
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547522}
[modify] https://crrev.com/39d5daaa736c7a127121b6b91dc1254177948a7b/chrome/browser/chrome_content_browser_client.cc

Comment 7 by jam@chromium.org, Apr 2 2018

Status: Fixed (was: Available)

Sign in to add a comment