"GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestHiDPI.ScrollOffset/1" is flaky |
|||||
Issue description"GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestHiDPI.ScrollOffset/1" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyYgsSBUZsYWtlIldHTEFuZFNvZnR3YXJlQ29tcG9zaXRpbmcvQ29tcG9zaXRpbmdSZW5kZXJXaWRnZXRIb3N0Vmlld0Jyb3dzZXJUZXN0SGlEUEkuU2Nyb2xsT2Zmc2V0LzEM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 4 2018
,
Apr 4 2018
So this test was never actually waiting for frame/metadata. With changes to the delivery of at_scroll_top, it will need to begin awaiting metadata arrival
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6af0971fc35893142e81227d4c4f4bbed4c6abb6 commit 6af0971fc35893142e81227d4c4f4bbed4c6abb6 Author: Owen Min <zmin@chromium.org> Date: Wed Apr 04 16:17:57 2018 Disable CompositingRenderWidgetHostViewBrowserTestHiDPI.ScrollOffset. Disable this test as it's flaky on Linux. Tbr: yiyix@chromium.org, fsamuel@chromium.org Bug: 828061 Change-Id: Ia890fb9392d2784e4b2c835665cc7a6427b1c0e4 Reviewed-on: https://chromium-review.googlesource.com/995588 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548082} [modify] https://crrev.com/6af0971fc35893142e81227d4c4f4bbed4c6abb6/content/browser/renderer_host/render_widget_host_view_browsertest.cc
,
Apr 4 2018
yes, I found the same. I will add some runloop and some callback to notify the tests when the render frame metadata is successfully sent.
,
Apr 4 2018
Detected 4 new flakes for test/step "GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestHiDPI.ScrollOffset/1". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyYgsSBUZsYWtlIldHTEFuZFNvZnR3YXJlQ29tcG9zaXRpbmcvQ29tcG9zaXRpbmdSZW5kZXJXaWRnZXRIb3N0Vmlld0Jyb3dzZXJUZXN0SGlEUEkuU2Nyb2xsT2Zmc2V0LzEM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Apr 5 2018
It seems like these "new" flakes were from before the test was disabled. Removing this from sheriff queue again.
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5989c742494ec0ff89bb49993774a5141e78a5da commit 5989c742494ec0ff89bb49993774a5141e78a5da Author: yiyix <yiyix@chromium.org> Date: Fri Apr 06 19:13:16 2018 VIZ: Fix flaky test CompositingRWHVBrowserTestHiDPI.ScrollOffset Test CompositingRenderWidgetHostViewBrowserTestHiDPI.ScrollOffset became flaky after using RenderFrameMetadata to notify RWHVBase about the Scroll Offset changes. This is because there may be some delay for the new RenderFrameMetadata(RFM) to arrive, so the RFM may still have the bool scroll_offset_at_top set to true, the initial value. Bug:828061 Change-Id: I8b0640cc02c11e143e4c2145e57654617b560ddc Reviewed-on: https://chromium-review.googlesource.com/996592 Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#548886} [modify] https://crrev.com/5989c742494ec0ff89bb49993774a5141e78a5da/content/browser/renderer_host/render_widget_host_view_browsertest.cc [modify] https://crrev.com/5989c742494ec0ff89bb49993774a5141e78a5da/content/public/test/browser_test_utils.cc [modify] https://crrev.com/5989c742494ec0ff89bb49993774a5141e78a5da/content/public/test/browser_test_utils.h
,
Apr 8 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by zmin@chromium.org
, Apr 4 2018Status: Assigned (was: Untriaged)