New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 828043 link

Starred by 3 users
Status: Assigned
Owner:
chanli@chromium.org
Cc:
█ kbr@chromium.org
geoffl...@chromium.org
liaoyuke@chromium.org
martiniss@chromium.org
jmad...@chromium.org
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 823289



Sign in to add a comment

Support flake detection for project ANGLE

Project Member Reported by st...@chromium.org, Apr 2 2018 
chromium-try-flakes currently only scans CQ builds in the project "chromium/chromium/src".

I assume that tryserver.chromium.angle is in another project. Two open questions for ANGLE folks:
1. What's the project name of those CQ jobs, "angle/angle"?
2. Are test results uploaded to test-results.appspot.com ? This is a prerequisite for flake detection.

On chromium-try-flakes side, we need to whitelist the project name at least, but some substantial change might be needed for data model as well.
But it might be easier to support ANGLE in Findit's new BQ-based flake detection which is being developed.

Comment 1 by kbr@chromium.org, Apr 2 2018

Cc: geoffl...@chromium.org martiniss@chromium.org
stgao@: we're in the process of converting these tryservers to LUCI but all of them except the Windows ones can be found here by searching for "ANGLE":

https://ci.chromium.org/p/chromium/g/luci.chromium.try/builders

The Windows ones can be found here:

https://ci.chromium.org/p/chromium/g/tryserver.chromium.angle/builders

Here's one example recent try run from Mac:

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_angle_rel_ng/288

Yes, the project is https://chromium.googlesource.com/angle/angle . It looks like these tryservers are uploading to test-results.appspot.com already.

Comment 2 by jmad...@chromium.org, Apr 2 2018 

(side note that several permutations of our tests fail to upload to test results because of issue 568149)

Comment 3 by kbr@chromium.org, Apr 2 2018

Blocking: 823289

Comment 4 by kbr@chromium.org, Apr 2 2018

Labels: -Pri-3 Pri-2

Comment 5 by st...@chromium.org, Sep 14

Owner: liaoyuke@chromium.org
Status: Assigned (was: Available)
The new flake detector for chromium is almost good to go.
If the support for ANGLE requires a small amount of work (I assume it uses the same recipe as chromium), let's do it.
liaoyuke@: would you mind a quick check?

Comment 6 by liaoyuke@chromium.org, Sep 14

Cc: liaoyuke@chromium.org
 Issue 878962  has been merged into this issue.

Comment 7 by ynovikov@chromium.org, Sep 21 

 Issue 887699  has been merged into this issue.

Comment 8 by ynovikov@chromium.org, Sep 21

Labels: Type-Feature
Looks like this is an older bug, so copying some info from  issue 887699  here.

ANGLE's CQ bots are listed in https://chromium.googlesource.com/angle/angle/+/master/infra/config/cq.cfg.

We have some are regular Chromium bots, so enabling Findit’s Flake Detector should be hopefully easily done for them:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android_angle_rel_ng
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android_angle_vk32_rel_ng
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android_angle_vk64_rel_ng
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android_angle_deqp_rel_ng
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android_angle_vk32_deqp_rel_ng
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android_angle_vk64_deqp_rel_ng
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_angle_rel_ng
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_angle_deqp_rel_ng
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_angle_ozone_rel_ng
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_angle_rel_ng
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win_angle_rel_ng
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win_angle_deqp_rel_ng

We also have some ANGLE standalone bots, not sure if there is something special about them requiring additional handling, but these are lower priority, they rarely flake:
https://ci.chromium.org/p/angle/builders/luci.angle.try/linux-clang-dbg
https://ci.chromium.org/p/angle/builders/luci.angle.try/linux-clang-rel
https://ci.chromium.org/p/angle/builders/luci.angle.try/mac-dbg
https://ci.chromium.org/p/angle/builders/luci.angle.try/mac-rel
https://ci.chromium.org/p/angle/builders/luci.angle.try/win-clang-x64-dbg
https://ci.chromium.org/p/angle/builders/luci.angle.try/win-clang-x64-rel
https://ci.chromium.org/p/angle/builders/luci.angle.try/win-clang-x86-dbg
https://ci.chromium.org/p/angle/builders/luci.angle.try/win-clang-x86-rel
https://ci.chromium.org/p/angle/builders/luci.angle.try/win-msvc-x64-dbg
https://ci.chromium.org/p/angle/builders/luci.angle.try/win-msvc-x64-rel
https://ci.chromium.org/p/angle/builders/luci.angle.try/win-msvc-x86-dbg
https://ci.chromium.org/p/angle/builders/luci.angle.try/win-msvc-x86-rel

Comment 9 by liaoyuke@chromium.org, Jan 8

Owner: chanli@chromium.org
Assigning to Chan, who is now owning the flake detector.
►

Sign in to add a comment