New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 828042 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

headless_browsertests failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Apr 2 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of jam@chromium.org

headless_browsertests failing on multiple builders

Builders failed on: 
- Win10 Tests x64: 
  https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64


 

Comment 1 by jam@chromium.org, Apr 2 2018

Labels: -Pri-2 Pri-1
Owner: irisu@chromium.org
Status: Assigned (was: Available)
I can't find a cause of the failures of HeadlessWebContentsTest.Focus, so assigning to you as the author.

Comment 2 by jam@chromium.org, Apr 2 2018

 Issue 828041  has been merged into this issue.

Comment 3 by jam@chromium.org, Apr 2 2018

Cc: jchin...@chromium.org wfh@chromium.org
btw this might be related to switching bots from Win 10 RS1 to RS2. see bug 818381. The rollout started on 3/29 and took roughly 24 hours to complete.

Comment 4 by jam@chromium.org, Apr 2 2018

Blocking: 818381

Comment 5 by jam@chromium.org, Apr 2 2018

Blocking: -818381
Actually this started failing on win7 as well, so it can't be related to the RS2 switchover.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fbc9c8e88d90196dba1469b8c173ea7f66e7524

commit 0fbc9c8e88d90196dba1469b8c173ea7f66e7524
Author: Owen Min <zmin@chromium.org>
Date: Tue Apr 03 17:34:05 2018

Disable HeadlessWebContentsTest.Focus

Disable this test as it consistently failed on Win10 and Win7.

Tbr: irisu@chromium.org
Bug: 828042
Change-Id: I5366a98999fca0911ae018a94ca479a3e6a308d9
Reviewed-on: https://chromium-review.googlesource.com/992881
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547749}
[modify] https://crrev.com/0fbc9c8e88d90196dba1469b8c173ea7f66e7524/headless/lib/headless_web_contents_browsertest.cc

Labels: -Sheriff-Chromium Type-Bug
Removing from sheriff queue since this has an owner and test has been disabled.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03212fef43d860b31ae8f29d360b3cdab11c2219

commit 03212fef43d860b31ae8f29d360b3cdab11c2219
Author: Johannes Henkel <johannes@google.com>
Date: Wed Apr 25 17:34:32 2018

Wait for focus before invoking document.hasFocus().

I'm not sure whether it should be this way - maybe
waiting for the page load (WaitForPageLoad) should
imply waiting for the focus as well; but this does
fix the previously flaky test. I've clarified the
name of the test also, since all this does is to
show that the two HeadlessWebContents instances
are independently focused at the same time.

R=caseq@chromium.com, eseckler@chromium.com

Bug: 828042
Change-Id: I174863b49ae525605a6aacb8750880d02fae3246
Reviewed-on: https://chromium-review.googlesource.com/1026993
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@google.com>
Cr-Commit-Position: refs/heads/master@{#553627}
[modify] https://crrev.com/03212fef43d860b31ae8f29d360b3cdab11c2219/headless/lib/headless_web_contents_browsertest.cc
[modify] https://crrev.com/03212fef43d860b31ae8f29d360b3cdab11c2219/headless/test/headless_browser_test.cc
[modify] https://crrev.com/03212fef43d860b31ae8f29d360b3cdab11c2219/headless/test/headless_browser_test.h

Sign in to add a comment