Issue metadata
Sign in to add a comment
|
4%-9.5% regression in system_health.memory_desktop at 547248:547380 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 2 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1694993f440000
,
Apr 2 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/1694993f440000 Make CapurePageText capture textContent only on dirty layout by xiaochengh@chromium.org https://chromium.googlesource.com/chromium/src/+/802df0571195f064c2bd77b513b86950eeb9f52a Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f397777d8c4e6855f580f0f2d1a1ddd9b0eec217 commit f397777d8c4e6855f580f0f2d1a1ddd9b0eec217 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Tue Apr 03 19:53:06 2018 Revert "Make CapurePageText capture textContent only on dirty layout" This reverts commit 802df0571195f064c2bd77b513b86950eeb9f52a. Reason for revert: suspected for causing memory regressions crbug.com/828026 and crbug.com/828027 Original change's description: > Make CapurePageText capture textContent only on dirty layout > > This is a partial revert for r536969 Change TranslateHelper to use a > TextContent-like text dump. > > r536969 is a workaround for a lifecycle violation bug that layout is > still dirty after running layout update. > > It turns out that textContent is not a good text dump for > TranslateHelper, as pages may hide arbitrary content (e.g., JSON) in > invisible text nodes, which can't be reliably filtered without checking > element style or layout. > > Since we don't always run CapturePageText() with dirty layout, there is > no need to always dump textContent. Hence, this patch partially reverts > r536969 that, we still dump innerText as long as layout is clean. We > dump textContent only when layout is dirty, which is enough to get > around the lifecycle violation bug. > > Bug: 826174 > Change-Id: I63e97832caa9858e67992847fb9a22f6405183cb > Reviewed-on: https://chromium-review.googlesource.com/984474 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Rachel Blum <groby@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547334} TBR=groby@chromium.org,tkent@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 826174 , 828026, 828027 Change-Id: I4c3200e5c7de0e6b3838ddcc40d53e751538f915 Reviewed-on: https://chromium-review.googlesource.com/992818 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#547796} [modify] https://crrev.com/f397777d8c4e6855f580f0f2d1a1ddd9b0eec217/third_party/WebKit/Source/core/exported/WebFrameContentDumper.cpp
,
Apr 4 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Apr 2 2018