NTP: Tapping in empty space of toolbar should focus omnibox |
||||||||||||||||
Issue descriptionM67 canary. iPad. iOS11.3. - enable UIRefresh - create a new tab - tap in the blank space in the toolbar between the back/forward/reload and the share button. expected: - omnibox focuses actual: - nothing happens This is a nice shortcut, not having it messes with my muscle memory.
,
Apr 4 2018
,
Apr 6 2018
,
Apr 11 2018
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f96d00c16a9db280802a42c83cdb5efdefd9f2d commit 2f96d00c16a9db280802a42c83cdb5efdefd9f2d Author: Justin Cohen <justincohen@google.com> Date: Tue May 01 04:44:06 2018 [ios] Add fake focus view to empty space on NTP. Allow users to tap and focus the omnibox it would normally appear on a non-ntp web page. Bug: 828002 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1270f4d4ef11a0a80bb74d441295d367544e8c18 Reviewed-on: https://chromium-review.googlesource.com/1034432 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#554996} [modify] https://crrev.com/2f96d00c16a9db280802a42c83cdb5efdefd9f2d/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm
,
May 1 2018
,
May 9 2018
Tested on M68.0.3425.0 Canary in iPad Pro(iOS 11.3.1) and iPad Mini(iOS 10.3.3) Tapping on blank space doesn't focus on omnibox Link to video: https://drive.google.com/file/d/1jUbzdhIXD3BNPe-2Xut94yBujc21zR8L/view?usp=sharing
,
May 9 2018
Oops, previous work was for iPhone, missed tablet work. tablet cl here: https://chromium-review.googlesource.com/c/chromium/src/+/1052308
,
Jun 11 2018
,
Jun 11 2018
,
Jun 12 2018
Not sure why is this blocked on 821807. That bug is for the steady-state location bar in fullscreen to exit fullscreen on tap. There is no fullscreen on NTP.
,
Jun 12 2018
stk@ see https://chromium-review.googlesource.com/c/chromium/src/+/1052308#message-e88e974b1f4fa82c96f28d58a5a5e343cb986ea1
,
Jun 26 2018
,
Jun 27 2018
,
Jun 27 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f61a5029f7920fffc57a115886732f97f347885 commit 1f61a5029f7920fffc57a115886732f97f347885 Author: Justin Cohen <justincohen@google.com> Date: Wed Jun 27 12:27:24 2018 [ios] Tapping in empty space of tablet NTP toolbar should focus omnibox. Bug: 828002 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id9f533ff3ec912a20535cdda17de9eb61d28b946 Reviewed-on: https://chromium-review.googlesource.com/1114746 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#570738} [modify] https://crrev.com/1f61a5029f7920fffc57a115886732f97f347885/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.h [modify] https://crrev.com/1f61a5029f7920fffc57a115886732f97f347885/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm [modify] https://crrev.com/1f61a5029f7920fffc57a115886732f97f347885/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
,
Jun 27 2018
,
Jun 27 2018
,
Jul 3
Verified in 69.0.3480.0 Canary, iPhone X iOS 11.4, iPad Air iOS11.4 Looks good. |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by twelling...@chromium.org
, Apr 3 2018